From: "Jan Beulich" Subject: Re: [patch rfc 1/3] xen arch header rework. Date: Thu, 05 Oct 2006 13:27:40 +0100 Message-ID: <4525165C.76E4.0078.0@novell.com> References: <20061005090543.625074000@suse.de> <20061005090633.493298000@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061005090633.493298000@suse.de> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: kraxel@suse.de Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org I'm not sure I like the tagging (as it'll likely result in even more overriding in the 32-on-64 patches), but I understand the motivation. >+ uint32_t unused; /* alignment */ Could you use _pad[0-9]* here as is done elsewhere, so that scripts can easily recognize the field as not needing copying (and namely not needing matching source and destination fields) when translating structures between architectures? Jan