From: "Jan Beulich" Subject: Re: [PATCH] Fix >4G i386 PAE grant table interface Date: Fri, 03 Nov 2006 09:42:49 +0100 Message-ID: <454B0F19.76E4.0078.0@novell.com> References: <454A2271.90000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <454A2271.90000@redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , Steven Rostedt Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Steven Rostedt 02.11.06 17:53 >>> >It has been discovered that i386 boxes with more than 4G of RAM would >randomly crash. It was traced to the interface of blktap using >gnttab_set_map_op. > >It would pass in the 64 bit pte entry, but the gnttab_set_map_op would >only take a 32 bit (on i386) unsigned long as a parameter. So we lose >the top 32bits. Could you use maddr_t here rather than uint64_t? For non-PAE i386 Linux, especially when using CONFIG_REGPARM, adding a useless argument slot seems wasteful... Keir - will this go into 3.0.3? Jan