From: "Jan Beulich" Subject: Re: [PATCH] Fix >4G i386 PAE grant table interface Date: Fri, 03 Nov 2006 09:28:43 +0000 Message-ID: <454B19DB.76E4.0078.0@novell.com> References: <454A2271.90000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Steven Rostedt , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 02.11.06 19:16 >>> >On 2/11/06 16:53, "Steven Rostedt" wrote: > >> This patch updates both the linux-2.6-sparse tree and the xen HV to use >> uint64_t instead of unsigned long for those particular functions. This >> patch has been tested on RHEL5 Beta on a box with 12G i386. >> >> Signed-off-by: Steven Rostedt > >Nasty bug. At least it affects only blktap. Thanks. Looking at this it would seem to me that the second call to gnttab_set_unmap_op in blkltap.c is missing the GNTMAP_contains_pte flag, affecting auto_translated_physmap guests. Signed-off-by: Jan Beulich Index: head-2006-10-30/drivers/xen/blktap/blktap.c =================================================================== --- head-2006-10-30.orig/drivers/xen/blktap/blktap.c 2006-10-26 12:10:54.000000000 +0200 +++ head-2006-10-30/drivers/xen/blktap/blktap.c 2006-11-03 10:00:44.000000000 +0100 @@ -908,8 +908,10 @@ static void fast_flush_area(pending_req_ return; } - gnttab_set_unmap_op(&unmap[invcount], - ptep, GNTMAP_host_map, + gnttab_set_unmap_op(&unmap[invcount], ptep, + GNTMAP_host_map + | GNTMAP_application_map + | GNTMAP_contains_pte, khandle->user); invcount++; }