From: "Jan Beulich" Subject: Re: [PATCH] Fix >4G i386 PAE grant table interface Date: Mon, 06 Nov 2006 09:21:32 +0100 Message-ID: <454EFE9C.76E4.0078.0@novell.com> References: <454B5FD1.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Steven Rostedt , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 03.11.06 21:43 >>> >On 3/11/06 14:27, "Jan Beulich" wrote: > >>> Do you want to do the patch, or would you like me to send another patch >>> that would do this change? >> >> Unless this was already committed, maybe Keir could do this on the fly? > >Already committed, but I'll consider patches. Don't use a 64-bit addr parameter to gnttab_set_{,un}map_op() when the upper 32 bits will never be used (i.e. i386 non-PAE). Signed-off-by: Jan Beulich Index: head-2006-10-30/include/xen/gnttab.h =================================================================== --- head-2006-10-30.orig/include/xen/gnttab.h 2006-09-21 09:57:46.000000000 +0200 +++ head-2006-10-30/include/xen/gnttab.h 2006-11-03 09:56:58.000000000 +0100 @@ -118,7 +118,7 @@ int gnttab_suspend(void); int gnttab_resume(void); static inline void -gnttab_set_map_op(struct gnttab_map_grant_ref *map, uint64_t addr, +gnttab_set_map_op(struct gnttab_map_grant_ref *map, maddr_t addr, uint32_t flags, grant_ref_t ref, domid_t domid) { if (flags & GNTMAP_contains_pte) @@ -134,7 +134,7 @@ gnttab_set_map_op(struct gnttab_map_gran } static inline void -gnttab_set_unmap_op(struct gnttab_unmap_grant_ref *unmap, uint64_t addr, +gnttab_set_unmap_op(struct gnttab_unmap_grant_ref *unmap, maddr_t addr, uint32_t flags, grant_handle_t handle) { if (flags & GNTMAP_contains_pte)