From: "Kirk Allan" Subject: [PATCH] netback: tx stalls with default credit_bytes Date: Mon, 06 Nov 2006 15:50:30 -0700 Message-ID: <454F59C6.39DB.0076.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartF8DCFF26.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --=__PartF8DCFF26.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline This situation happens when netif->credit_bytes is using the default of ~0UL, effectively -1. Once the current tx packet size is greater than the netif->remaining_credit, transmits will stall until netif->remaining_credit wraps back to ~0UL in tx_add_credit(). The min(netif->remaining_credit + netif->credit_bytes, max_burst) has the effect of decrementing netif->remaining_credit by 1. The min will continually be less than the current tx packet size until tx_add_credit() is called packet size times which allows netif->remaining_credit to wrap back to ~0UL. The patch splits the min() into two steps to eliminate the case of adding by -1. signed-of-by Kirk Allan --=__PartF8DCFF26.0__= Content-Type: application/octet-stream; name="netback.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="netback.diff" LS0tIGEvbGludXgtMi42LXhlbi1zcGFyc2UvZHJpdmVycy94ZW4vbmV0YmFjay9uZXRiYWNrLmMJ MjAwNi0xMC0yNiAwODo0NjowNi4wMDAwMDAwMDAgLTA2MDAKKysrIGIvbGludXgtMi42LXhlbi1z cGFyc2UvZHJpdmVycy94ZW4vbmV0YmFjay9uZXRiYWNrLmMJMjAwNi0xMS0wNiAxMDoyNjoyNC4w MDAwMDAwMDAgLTA3MDAKQEAgLTgxNSw2ICs4MTUsNyBAQAogc3RhdGljIHZvaWQgdHhfYWRkX2Ny ZWRpdChuZXRpZl90ICpuZXRpZikKIHsKIAl1bnNpZ25lZCBsb25nIG1heF9idXJzdDsKKwl1bnNp Z25lZCBsb25nIG1heF9jcmVkaXQ7CiAKIAkvKgogCSAqIEFsbG93IGEgYnVyc3QgYmlnIGVub3Vn aCB0byB0cmFuc21pdCBhIGp1bWJvIHBhY2tldCBvZiB1cCB0byAxMjhrQi4KQEAgLTgyMywxMCAr ODI0LDEwIEBACiAJbWF4X2J1cnN0ID0gUklOR19HRVRfUkVRVUVTVCgmbmV0aWYtPnR4LCBuZXRp Zi0+dHgucmVxX2NvbnMpLT5zaXplOwogCW1heF9idXJzdCA9IG1pbihtYXhfYnVyc3QsIDEzMTA3 MlVMKTsKIAltYXhfYnVyc3QgPSBtYXgobWF4X2J1cnN0LCBuZXRpZi0+Y3JlZGl0X2J5dGVzKTsK KwltYXhfY3JlZGl0ID0gbWF4KG5ldGlmLT5yZW1haW5pbmdfY3JlZGl0ICsgbmV0aWYtPmNyZWRp dF9ieXRlcywKKwkJbmV0aWYtPmNyZWRpdF9ieXRlcyk7CiAKLQluZXRpZi0+cmVtYWluaW5nX2Ny ZWRpdCA9IG1pbihuZXRpZi0+cmVtYWluaW5nX2NyZWRpdCArCi0JCQkJICAgICAgbmV0aWYtPmNy ZWRpdF9ieXRlcywKLQkJCQkgICAgICBtYXhfYnVyc3QpOworCW5ldGlmLT5yZW1haW5pbmdfY3Jl ZGl0ID0gbWluKG1heF9jcmVkaXQsIG1heF9idXJzdCk7CiB9CiAKIHN0YXRpYyB2b2lkIHR4X2Ny ZWRpdF9jYWxsYmFjayh1bnNpZ25lZCBsb25nIGRhdGEpCg== --=__PartF8DCFF26.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartF8DCFF26.0__=--