From: Eric Sandeen Subject: Re: [PATCH 2/3] new_inode_autonum: convert filesystems to use new function Date: Thu, 09 Nov 2006 11:16:32 -0600 Message-ID: <45536270.2040505@sandeen.net> References: <1163085883.21469.46.camel@dantu.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@osdl.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:64152 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1424133AbWKIRQi (ORCPT ); Thu, 9 Nov 2006 12:16:38 -0500 To: Jeff Layton In-Reply-To: <1163085883.21469.46.camel@dantu.rdu.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Jeff Layton wrote: > This patch converts all in-tree filesystems that blindly use the i_ino > value given by new_inode to use new_inode_autonum. Also fix up a few > other cases where i_ino might not end up being unique. After looking at this, since you have to change all of these filesystems anyway, I'm not sure there's a lot of value in having new_inode_autonum(); they all previously called new_inode() and then filled in a few fields of the new inode. Why not just call new_inode(), and add a call to inode->i_inum = iunique(sb, 0)? We don't have new_inode_autouid() or new_inode_autoatime(), why is i_ino special in this regard? -Eric