From: "Jan Beulich" Subject: Re: [PATCH] Bugfix: Don't use function pointers to inline functions Date: Thu, 30 Nov 2006 12:56:30 +0000 Message-ID: <456EE30E.76E4.0078.0@novell.com> References: <200611301131.28678.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200611301131.28678.Christoph.Egger@amd.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >There's code, which use inline functions on function pointers. >This is IMO a bug. I disagree - inline is a hint, not a requirement (other than one might say about __attribute__((__always_inline__)), or when functions are declared/ defined extern inline). Hence I would expect the compiler to generate out-of-line instances when addresses of the function are taken. Have you brought this up with the gcc folks? Jan