From: "Jan Beulich" Subject: Re: [PATCH] add canonical address checks to HVM Date: Fri, 01 Dec 2006 08:05:02 +0000 Message-ID: <456FF03E.76E4.0078.0@novell.com> References: <456DAFBE.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 30.11.06 18:55 >>> >On 29/11/06 15:05, "Jan Beulich" wrote: > >> Add proper long mode canonical address checks to PIO emulation and MSR >> writes, the former paralleling the limit checks added for 32-bit guests. >> Also catches two more cases in the MSR handling code where only ECX >> (rather than RCX) should be used. >> >> Signed-off-by: Jan Beulich > >I wonder if we would be better consistently *removing* the canonical-address >checks? It's not a security issue after all -- the check is done in hardware >only to prevent code from ever depending on being able to use the high >address bits for software flags. I think it is harmless to deviate from >native behaviour on this issue and makes our emulation code smaller and >simpler. I think it might be a security issue: - In MSR writes, are you certain there's not going to be any problem now or in the future when the state gets actually loaded into CPU registers? - In memory accesses, at least until no failures to read/write guest memory are being ignored anymore. Jan