From: "Jan Beulich" Subject: [PATCH] x86: fix NMI delivery to dom0 Date: Mon, 12 Feb 2007 13:06:03 +0000 Message-ID: <45D0744B.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org As I understand it, the condition for raising the respective softirq was inverted. Signed-off-by: Jan Beulich Index: 2007-02-07/xen/arch/x86/traps.c =================================================================== --- 2007-02-07.orig/xen/arch/x86/traps.c 2007-02-07 16:32:43.000000000 +0100 +++ 2007-02-07/xen/arch/x86/traps.c 2007-02-12 13:53:44.000000000 +0100 @@ -1804,7 +1804,7 @@ static void nmi_dom0_report(unsigned int set_bit(reason_idx, nmi_reason(d)); - if ( test_and_set_bit(_VCPUF_nmi_pending, &v->vcpu_flags) ) + if ( !test_and_set_bit(_VCPUF_nmi_pending, &v->vcpu_flags) ) raise_softirq(NMI_SOFTIRQ); /* not safe to wake up a vcpu here */ }