From: "Jan Beulich" Subject: [PATCH 1/8] 2.6.17: proper mutex use Date: Wed, 14 Feb 2007 15:57:02 +0000 Message-ID: <45D33F5E.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Mutexes are supposed to not use the old semaphore technique anymore. Signed-off-by: Jan Beulich Index: head-2007-02-08/drivers/xen/balloon/balloon.c =================================================================== --- head-2007-02-08.orig/drivers/xen/balloon/balloon.c 2007-02-08 17:07:13.000000000 +0100 +++ head-2007-02-08/drivers/xen/balloon/balloon.c 2007-02-08 17:09:47.000000000 +0100 @@ -60,7 +60,7 @@ static struct proc_dir_entry *balloon_pde; #endif -static DECLARE_MUTEX(balloon_mutex); +static DEFINE_MUTEX(balloon_mutex); /* * Protects atomic reservation decrease/increase against concurrent increases. @@ -321,7 +321,7 @@ static void balloon_process(void *unused int need_sleep = 0; long credit; - down(&balloon_mutex); + mutex_lock(&balloon_mutex); do { credit = current_target() - bs.current_pages; @@ -340,7 +340,7 @@ static void balloon_process(void *unused if (current_target() != bs.current_pages) mod_timer(&balloon_timer, jiffies + HZ); - up(&balloon_mutex); + mutex_unlock(&balloon_mutex); } /* Resets the Xen limit, sets new target, and kicks off processing. */