From: "Jan Beulich" Subject: Re: Fwd: Re: struct page field arrangement Date: Thu, 01 Mar 2007 11:45:58 +0000 Message-ID: <45E6CB06.76E4.0078.0@novell.com> References: <45E69FFD.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 01.03.07 11:22 >>> >On 1/3/07 08:42, "Jan Beulich" wrote: > >> Having looked a little into the disabled SPLIT_PT_LOCK issue on Xen, I >> realized that is shouldn't be too difficult to re-enable it (at least in some >> cases). > >How does pagetable locking work in modern Linux kernels? It seems that >updates of ptes are protected by a per-page lock or the mm lock, and >population of page directory entries is protected by the mm lock, but that >there is no synchronisation with read-only pagetable walks. Does this mean >that sections of pagetable hierarchy are never reaped from a process until >it dies? Yes, that's my understanding. >Can we confident that the mm_pin/mm_unpin code (which walks pagetables and >has to find every page to make every one read-only or writable) is safe? >Presumably for this to be true we need to be sure that noone can meanwhile >concurrently be populating the pagetable we are walking with extra >pgds/puds/pmds/ptes... Since the pin/unpin walking only cares about pgd/pud/pmd entries, synchronization is guaranteed through mm->page_table_lock. The pte lock is used only for leaf entries, which are of no concern to (un)pinning. Jan