Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 952B8C433EF for ; Fri, 22 Apr 2022 22:46:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6425082385; Sat, 23 Apr 2022 00:45:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jwlXKzoY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9185083C54; Sat, 23 Apr 2022 00:45:54 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE130810E6 for ; Sat, 23 Apr 2022 00:45:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x834.google.com with SMTP id bz24so6552712qtb.2 for ; Fri, 22 Apr 2022 15:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=z8a2acPQDXH3wqR9nd8gXn87bGdD/xfWxWiG5p7Uihc=; b=jwlXKzoYcS6E1fxgfnUW6aSGEobDx8Ao6mFIfhwzDQpC4wxa/c4nBOv4fm1wGq17/C Wj1rTLmG6M2URORXpnYHcOqGP5uV0Zbipl/bNsZsL4PBwIDETXuNTTO0HbdWELOV/G24 BrN3uDWDj1yp2F8mvC0LrpQtYcE+rJ9NCM7E2uyH6jUBCYJUy6rYbhxrRd8rZGdl6Q3l 26mcqMcEAagGOAXoud9K+6UGl2G+ZxhBs4ZbQF/3wmYi3Ruxmz5/qDfzRx1gvnzyay+M cthZb1tBIQilBqLq827ySitXg2bPTDlqGeUUc2PDXYJ4vd0cy8K1kyd+LSJ0OjjaG5Di UhJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z8a2acPQDXH3wqR9nd8gXn87bGdD/xfWxWiG5p7Uihc=; b=ohNIAkMVTEjnqKKXmWC5D3PNx3Vr9TO9pi+Cu0fmuGG/J3N8IyonvCMXeKHbCbz564 v97AaZO7UONdK1/yd6s29aHP6/axiWJiAoFig6LyoQganSQLe65ANFNRfv5ojYr71r4L 7c5NX9C5IunhxTOmxjR7fPrwKHoH0VhgBN+xaX6gaMR8FUYybiy2krZlTbphyNHZZgyd MShtTiHY84Kd/N7fvkbN2aeA60Eb4F86bn41R+LK1CZR+PDiAJ17uQx6isOprKYbuJ7N ylA02BmDgdNdSFPx/HCd8ovJuY4QAo1uaj6YgwOKnmqc9Yzr+LtKRU1+AtaerGWGKHaA HWtg== X-Gm-Message-State: AOAM533NNaEzpr7TMKKT8V5Q6n0j/1yl6sLHRy5Tz7PcfPT2BJHMWazA DuSzccy3cJZOpIOSOdGC4Sk= X-Google-Smtp-Source: ABdhPJzG1AHAYUl4m0FX9TNF8NwHSCk4k2FTgZLqA5MD64qfBf04udmhgjPY2y5DMZFlFFxjs8gLKA== X-Received: by 2002:a05:622a:151:b0:2f1:fe9f:9177 with SMTP id v17-20020a05622a015100b002f1fe9f9177mr5012435qtw.628.1650667550564; Fri, 22 Apr 2022 15:45:50 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id v7-20020a379307000000b0069c0a2afc55sm1500080qkd.123.2022.04.22.15.45.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 15:45:50 -0700 (PDT) Subject: Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag To: Marek Vasut , u-boot@lists.denx.de Cc: Patrice Chotard , Patrick Delaunay , Simon Glass , Steven Lawrance References: <20220422131555.123598-1-marex@denx.de> <768910e4-b324-9956-4035-50798e0a3d74@denx.de> From: Sean Anderson Message-ID: <45ab9552-34ed-6d18-c99b-6287d0c54c3a@gmail.com> Date: Fri, 22 Apr 2022 18:45:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <768910e4-b324-9956-4035-50798e0a3d74@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/22/22 9:52 AM, Marek Vasut wrote: > On 4/22/22 15:49, Sean Anderson wrote: >> On 4/22/22 9:15 AM, Marek Vasut wrote: >>> Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or >>> uclass in .bind(), to indicate such driver instance should be probe()d >>> once binding of all devices is complete. >>> >>> This is useful in case the driver determines that hardware initialization >>> is mandatory on boot, and such initialization happens only in probe(). >>> This also solves the inability to call device_probe() from .bind(). >> >> So why not add an init_leds function to init_sequence_r? > > Because this flag is generic solution and not hack specific to LEDs. Isn't init_sequence_r the generic solution? Every device gets probed that way (or directly as a result of a command). --Sean