Return-Path: From: Sven Eckelmann Subject: Re: [PATCH v3 net] batman-adv: set .owner to THIS_MODULE Date: Sun, 15 Nov 2020 11:40:51 +0100 Message-ID: <4602363.31r3eYUQgx@sven-edge> In-Reply-To: <20201115103004.30618-1-ap420073@gmail.com> References: <20201115103004.30618-1-ap420073@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4272036.LvFx2qVVIh"; micalg="pgp-sha512"; protocol="application/pgp-signature" Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: To: mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc, b.a.t.m.a.n@lists.open-mesh.org, Taehee Yoo Cc: ap420073@gmail.com --nextPart4272036.LvFx2qVVIh Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann To: mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc, b.a.t.m.a.n@lists.open-mesh.org, Taehee Yoo Cc: ap420073@gmail.com Subject: Re: [PATCH v3 net] batman-adv: set .owner to THIS_MODULE Date: Sun, 15 Nov 2020 11:40:51 +0100 Message-ID: <4602363.31r3eYUQgx@sven-edge> In-Reply-To: <20201115103004.30618-1-ap420073@gmail.com> References: <20201115103004.30618-1-ap420073@gmail.com> On Sunday, 15 November 2020 11:30:04 CET Taehee Yoo wrote: > If THIS_MODULE is not set, the module would be removed while debugfs is > being used. > It eventually makes kernel panic. > > Fixes: 9e466250ede3 ("batman-adv: Prefix bat_debugfs local static functions with batadv_") This Fixes: is bogus. The code was already present with the first commit c6c8fea29769 ("net: Add batman-adv meshing protocol"). I have now changed it before it was applied to the net branch. > net/batman-adv/log.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/batman-adv/log.c b/net/batman-adv/log.c > index a67b2b091447..c0ca5fbe5b08 100644 > --- a/net/batman-adv/log.c > +++ b/net/batman-adv/log.c > @@ -180,6 +180,7 @@ static const struct file_operations batadv_log_fops = { > .read = batadv_log_read, > .poll = batadv_log_poll, > .llseek = no_llseek, > + .owner = THIS_MODULE, > }; > > /** > General info: This causes a merge problem with the net-next branch [1] because the debugfs files were dropped in preparation of the Linux 5.11 release in 2021. I might rebase the currently pending patches for net-next to avoid this weird merge conflict. Kind regards, Sven [1] https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next --nextPart4272036.LvFx2qVVIh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAl+xBbMACgkQXYcKB8Em e0aVfQ//VRRU7RnW5O8RTGtgk/Qb5MJTTBetkq13lttk/hU2bpmcAlXqvWhwwKje D2cjoc4hDbyAb4uZQN/JWVFGAoLNa64pMlIidhaG93kJ6BOtHj/z0q9IWTziMaH0 NS65OpNv9bVCPn89A95zKsXSTkSAd+1t/ruAzI5hD7XFsxYNiaRd/IgcmURaa7u9 Wn2MYnzPHBs2d2fJg2rw49nN13UtaE/i1dpa79TB/v8pvxVaikiWgWXIX497OeJ0 6OVPU/c7NKMeoChDJ9tiQ8kNTiesbclX77fjMUvz0tltpq4CGrB+kfs0AeqsF+fg zA9q/7kfogRwxM7VWoUN7GJexZUtXK/w4mP/UXTYVDxb6cKTCo2vHoSfQs+4FKtz tk1XJco7Nl+zK4kBvCmBuyMCBaoqPp1DDoqpSallGR4BT3v93e39DtXJuHwkt/DT ly1fYL0sIkE9c2Vu59uebP6C4DfQ4SQ0t7+7Waqj+SzDCRltCdsJrFJVwxMBjcHn Tih9EJKey3mQxfW5GcIVsAbaXrydSIMhCiMBTPI8lj3QCeSDrR1IoVSxvX+2JIiC NSgXDy0Ty7KWFyDtSbUg+RfFKL8mhgivUYxnB+ce3Ovft1k6w/BVNvl6dYpZVrP9 F/WmBaiwwQ/4HFuWnhabBXlDvWh6mKsAR8ruAjl/9+bHD5mwzQ0= =Mxg5 -----END PGP SIGNATURE----- --nextPart4272036.LvFx2qVVIh--