From: Chris Subject: Re: [PATCH] pciback: restore PCI BARs on D3->D0 transition Date: Tue, 03 Apr 2007 11:52:07 -0400 Message-ID: <46127827.5060302@tycho.ncsc.mil> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Alex Williamson Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > On 26/3/07 21:23, "Alex Williamson" wrote: > >> don't think we necessarily need to go to that extent for pciback, but it >> does appear to be pciback's responsibility to restore some state on the >> card when transitioning out of D3, since it is effectively the driver >> for the device. > > Well, really it's supposed to be a filter (and perhaps translator) for PCI > config space accesses. It's not really a driver. But obviously something > like this is needed. Sorry for the delay, I've been out of the office for a while. Indeed pciback was intended to be more of a filter than a driver. For the time being it seems reasonable to implement BAR-related PM functions in pciback as you've done (many thanks for that). As time permits I'll double-check that your solution makes the fix in the most appropriate location. Cheers, Chris