From: "Jan Beulich" Subject: [PATCH] 32on64 vCPU cleanup fix Date: Thu, 26 Apr 2007 16:55:18 +0100 Message-ID: <4630E786.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Since vcpu_destroy_pagetables() clears v->arch.guest_table for hvm vCPUs, it must be avoided to free the page with MFN zero. Signed-off-by: Jan Beulich Index: 2007-04-18/xen/arch/x86/domain.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- 2007-04-18.orig/xen/arch/x86/domain.c 2007-04-26 13:52:22.0000000= 00 +0200 +++ 2007-04-18/xen/arch/x86/domain.c 2007-04-26 13:53:14.000000000 = +0200 @@ -252,9 +252,12 @@ static int setup_compat_l4(struct vcpu * =20 static void release_compat_l4(struct vcpu *v) { - free_domheap_page(pagetable_get_page(v->arch.guest_table)); - v->arch.guest_table =3D pagetable_null(); - v->arch.guest_table_user =3D pagetable_null(); + if ( !pagetable_is_null(v->arch.guest_table) ) + { + free_domheap_page(pagetable_get_page(v->arch.guest_table)); + v->arch.guest_table =3D pagetable_null(); + v->arch.guest_table_user =3D pagetable_null(); + } } =20 static inline int may_switch_mode(struct domain *d)