From: "Charles Coffing" Subject: [PATCH] remove unnecessary execute perms Date: Tue, 22 May 2007 16:09:45 -0400 Message-ID: <4652F88E.D169.003C.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi, rpmlint complains that various blktap files are installed with unnecessary execute permissions: E: xen-devel spurious-executable-perm (Badness: 100) /usr/lib64/libblktap.a E: xen-devel spurious-executable-perm (Badness: 100) /usr/include/blktaplib.h The patch below fixes the problem. It applies against xen-unstable. Thank you. Signed-off-by: Charles Coffing diff -ru xen-unstable.hg/tools/blktap/lib/Makefile xen-unstable/tools/blktap/lib/Makefile --- xen-unstable.hg~/tools/blktap/lib/Makefile 2007-03-12 09:01:04.000000000 -0600 +++ xen-unstable.hg/tools/blktap/lib/Makefile 2007-05-22 14:01:46.000000000 -0600 @@ -42,10 +42,10 @@ install: all $(INSTALL_DIR) $(DESTDIR)/usr/$(LIBDIR) $(INSTALL_DIR) $(DESTDIR)/usr/include - $(INSTALL_PROG) $(LIB) $(DESTDIR)/usr/$(LIBDIR) + $(INSTALL_DATA) $(LIB) $(DESTDIR)/usr/$(LIBDIR) ln -sf libblktap.so.$(MAJOR).$(MINOR) $(DESTDIR)/usr/$(LIBDIR)/libblktap.so.$(MAJOR) ln -sf libblktap.so.$(MAJOR) $(DESTDIR)/usr/$(LIBDIR)/libblktap.so - $(INSTALL_PROG) blktaplib.h $(DESTDIR)/usr/include + $(INSTALL_DATA) blktaplib.h $(DESTDIR)/usr/include clean: rm -rf *.a *.so* *.o *.rpm $(LIB) *~ $(DEPS) xen TAGS