Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1282DC433EF for ; Fri, 10 Jun 2022 13:50:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 87A4C843F1; Fri, 10 Jun 2022 15:50:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="MJYDb7xB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DC70C843E7; Fri, 10 Jun 2022 15:50:20 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0604.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::604]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0891E843F9 for ; Fri, 10 Jun 2022 15:50:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mbrugger@suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORqi6NQiuqlB8PFfaJ7qBINrGf0FxORErIS6C0NzFEySGb8imTK/zFEtcbcEgwhORJma/z4XHGr6JXOWtIdW28gsHlucMMxJajtLHhi1vwSs5k5DxDZwsXvE8Bio3E+7RgIf9PupYn47Qoww9Lqar7XXwBYFRvbbqqYkwHxqJ62b68qsyj6kT997pFVsUY4RG1o/TMsmsebmf/2QfHU7b/9Ig5j93QYXtqUEbe1c/rZIT0XJjlkjpS1hkMY+PTTsF3zFWUBeMeQjn/KerXCR+d0R67TAuz6LpoHZIs6jWS8PcL8D3MTbL8oK+rahLmR2g2LYwZK+Zjfwpn48I+ZaLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0lkxiP2gmd6HxWI4z8yDaINgBd/ZSEYS466S6/tp6XM=; b=WNjq9sidPXngx8pgRim4Quxq54fV2aTogpDk2xuW5ffTwe4uyyITTxaaZCBtmSZEs859Vy5oXIjLfpAQmc2NIy7juKwpB0nf5bFgsfNktTQvfUIw14Vj4W2rdsb7sJI2B6q1sKLkNX+fXIHTX8OMFvELIDnFuMHxZnCXiKW8/guz3Au1F8ImY6NH+MRwQp0V52oYmZ3fDTxExdrug+E94w0DSmUsmz9usvx5Z2V7f/mgn5uCsrnCdLZRg45VOoFfRAbFBXSINHX3mwLWxZsqbAserjWTmJuGTQRdZdQXrT+dWcN+2qh5x7H/u6ZKAP+rQTmV2lEMaJcf/HlHpibpqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0lkxiP2gmd6HxWI4z8yDaINgBd/ZSEYS466S6/tp6XM=; b=MJYDb7xBO8MmStkO4vVHGe/0dzGrpHV/O3Go1h6QUNXJJTQabKRGzwJVJFwgkdrtoen0K+YJBUzCcDmGG3heLMZEsPY/Tum5VBADc+siFWRxubQaZ2TJOMCsTktH+XmLB549cW0/qr2WkHyDcl2Z7viNnxIehOZB8zrxDV18eQ/dYzrztWIye0vX/qwNJ7cOaS51SK9wLWztaKnXbWC7X9KPeQl0TNOHQu/SuIko3TPmUlEpYPMqKHZHrgsgNNZ9oKHRMZ32sJCvmQWuo5H3UpwblMUwEyI+vYMypECQenh6kzAkqDsy+8rA3/rrQuE1iMLiWBlH0yRSVFZq79TIag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB5366.eurprd04.prod.outlook.com (2603:10a6:20b:9d::19) by AM0PR04MB5442.eurprd04.prod.outlook.com (2603:10a6:208:120::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Fri, 10 Jun 2022 13:50:13 +0000 Received: from AM6PR04MB5366.eurprd04.prod.outlook.com ([fe80::94ec:7991:fd57:69c8]) by AM6PR04MB5366.eurprd04.prod.outlook.com ([fe80::94ec:7991:fd57:69c8%5]) with mapi id 15.20.5332.012; Fri, 10 Jun 2022 13:50:13 +0000 Message-ID: <46807e17-3a9d-e510-1795-a43c860c271d@suse.com> Date: Fri, 10 Jun 2022 15:50:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 0/7] Add video damage tracking Content-Language: en-US To: Alexander Graf , u-boot@lists.denx.de Cc: Heinrich Schuchardt , Anatolij Gustschin , Simon Glass , Da Xue References: <20220609225921.62462-1-agraf@csgraf.de> From: Matthias Brugger In-Reply-To: <20220609225921.62462-1-agraf@csgraf.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0105.eurprd04.prod.outlook.com (2603:10a6:20b:31e::20) To AM6PR04MB5366.eurprd04.prod.outlook.com (2603:10a6:20b:9d::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01d8cb3b-bd92-4784-a544-08da4ae82439 X-MS-TrafficTypeDiagnostic: AM0PR04MB5442:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dv6q80FEEaFVol7FV71Shr6cVpzqbgL7YSVMCSwZwgKz7l4wD3Q8xRGwDe7wrhBpa7V8lqv8tBO5Y0UkrlvnR2YILDaTrAaDGvo65IcxrK9HECGcbuDa5zeY8EIuoo1zAiH9EwVSyNPZ3rnI5NC5oGKViVJKG30bRoSk0mTkGNL+msjw3mDOQPzklcuWvOwWB31A78qqs+xIR8GrQwWKAeBeFqO9WFLfSecJ9XXxw0jGO2nUX4k+ER1agoRn0txNYflLqo65M3e7jpzRJrPBcGJXpYsb70UeSxcg49qbX13cGnU+kJ/2OZUCb93H9BBewGD1GDhTSZAXXd/TR+Q8VdP583O0uyaUoCejrnStyr7jXXZPj17EEU6C5rHuW5aLZFOwaxj93p95aJ05nbsPAut5xDNVkmHBo8SYDcA9EMsNFBYX8LcY8gZQYS0AjubK1+K6Ns4wNCt4HyanqrTzHrb25vPiflrUu2g/u7fd15Rf9Ogcf3kPvZbp33ZGnGh7s63Ske1EjXmzzb7TghbhXWQsYIuONnUtZy0wxtOrXuLM/MrepOlv+0ujdwE0mD5I/JrTqFS31t2SMaZHVLwRt4iHSnXNrbfCnc4eWa24wsXTyENIMiUOlCEeOZPZDd+SyvXcIxA1hij4gfpAp3YxVXHBS9zKGPy/OVzJrVZsoKnFt6WZo9Vqw9Ct6JctiKOvGoCTVkL3NkM6m62BllpXF+1WVt1rln0wRhsM+MrU4eQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5366.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(8676002)(4326008)(6486002)(66946007)(36756003)(53546011)(66476007)(66556008)(5660300002)(6506007)(31686004)(54906003)(6512007)(26005)(316002)(83380400001)(508600001)(186003)(2616005)(31696002)(86362001)(2906002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGJNQUo0d1ppeDNpWkQ3NzVwWDFPZGxnOUFzOU9sQ1QzMkpNMzhrbk5NZVJa?= =?utf-8?B?OWZWSVIrWVovWFVtRHpXdDN3Z2dSaUVIZWZlTzlxcE82NGNlNWhXc1ExZjBm?= =?utf-8?B?ZUdjdjNkK0pkSEdIQmYyRzdMN2VGVFo1UGhCT0t1cWVyelBydko5dGhoc0lI?= =?utf-8?B?czRDeXdtSVN3RDNRejdGTWRRLzc5N2ppdGRxS3Z6V0pVWjUyS2tsSFMrWjRX?= =?utf-8?B?bWlHclVOamcxNjJNVCtWTmxtcGNMRlBOVHY2OHJDWjBKZkpkY3c4eFozakFM?= =?utf-8?B?S2duWllsWTJXTmRqbTI0RHppbEI5VzVtRVVjcnFaemNSZmtuMSswMmEwQXAy?= =?utf-8?B?K21scXA1RkExUW9xQi82SzNSWlhBYXRnL05UTjVyNTFtYmVUcVZ3NWZVcVZZ?= =?utf-8?B?UlRaaU5sQ1VDZ3c3NmUrZytFczNETU9LRm1XVzVrdE02TWxGRWVXaVlRaGFH?= =?utf-8?B?VXlVajFUditROWtSaFFTWWw4VVFTRGtqMHp6bkptYll2bGRvMlNJTFpWc0xy?= =?utf-8?B?V0tYUXN0L1UxSXB2RUZ5MENEdWdHTEpkVE5DQzl4alk4RTYvQU9yNkpob24y?= =?utf-8?B?Vkc2dlNuQzBlZHd6NlRoaFBsTHNMOHRKOEtZd005OEpRQVo3eUtydk9qdDhm?= =?utf-8?B?RzZuc1BXU1hERWtCRzRRYk10VWVZcGQ4Vktyd0U3Vml2TVU1NElyenA4OGsr?= =?utf-8?B?ejV5NUNxNkMrWjVNT1dmQVl0MWFBckw3WmI5bjQrVENYL3BwUUg5TzZxSnRV?= =?utf-8?B?MURVSGlsZXNpazBNSXFJeVY4c0N5M01mSVF5YUVPYUhmVjFnb0pQN3NHaFdw?= =?utf-8?B?UDFaZjh4TWRMazNSM1VSMGZHclpNdFM5eWpxRTgxM3dxQ21wSkp3UjB6bkJV?= =?utf-8?B?bHAzVENZZVhEWGpNMmxPTkRXRURUTko3TUFLSFJFR3FZbHhMSks2dkZvclNw?= =?utf-8?B?VGppcUhpdkNGeWlQSmVRQzdDemZIWTBYZUlnWFdRUmdQTERGSWJndUFBbEJT?= =?utf-8?B?ZWRqNGM3S2E5WUJENllFSzM1Z25GNUVqY0dNeFJsdWZSYXhuOGxIb0E3QUxj?= =?utf-8?B?b1MwS3NtMmx1SHJhTktwN3o1YW0rMGlCblZaa1hJYUZtVmNnWk5naERWZEsz?= =?utf-8?B?UUFjLy9ieDZZMy96T2NGNURQN0N0cUlROW8rNmttcEpGazR1YnRldG9KTEpx?= =?utf-8?B?RjlOOGlYN0VsazRZZFNRSnBIa0NjcVE4MGxUTU9ORHJsQTlWMEh2VGErVkkz?= =?utf-8?B?RFNnR0NrZ1h6NXJ0ZDRBUWN4WDV5YzRPb0V5UUszUHVMVW9HTkxMdWFJOWk3?= =?utf-8?B?Q0kxb0hOVk1uRjk1dEh1dVJVelpldnlhMzdJVUEwYS8zZnA0Q1ZWVXdzSVB4?= =?utf-8?B?OUIyQUJDYzB4cDJRdW13SFZHN0htN05GS1d5Z2VMa3pCNytBd3pnR0YvRXRE?= =?utf-8?B?eFhqSldXdUtKcXFSVmluSzlyREtpTDdGajd4UEZLekxpbFV3aS8zeFZ6dm01?= =?utf-8?B?WFJqcHZPbUJOd0Q5STlMN3ZQYU5zZUhIT3IwZUQxbERkdlJ4amk5OWhBc0hw?= =?utf-8?B?QjYrZ0Z4dUtKeHhxY1k5SExHRVpwRE5POTlXTVMzMDNLT05tN2ZPSDVyRXJC?= =?utf-8?B?NlNvSlRBZVRmNXVQeWRMRFVVYVBab3Z5YlZjVWQ5QkpSQTQ3WmJEWUhUV2pZ?= =?utf-8?B?R05YOVZ5cmRtTXVQWXJkVjFYc0V4a0prV0dMWmRnUVNGbWRkR0RwMSs3VjVm?= =?utf-8?B?OGZHTUgreVU5NHJubHFERjNTOHJzb200S0l2ZSttNUg0ek12c2RnOUtKSFFX?= =?utf-8?B?ZGlPd0d6ZkMrOFlpK0ZhN0dEL0NEVUljUDNkSXI1Rjd6SGIzKzBLcFhaM0Js?= =?utf-8?B?YmlNRlNjdlcyY285WHloUUpidXFmUk91Q1hZYlVJWG1IeXU4TDZPWk8zZ09O?= =?utf-8?B?T3Q1SGQ5eVgrWWx5cG94M3BVUnRpdVEya1d0SlRtS0NEWmpJR0RLMDR5SHBO?= =?utf-8?B?bXlsdURTa1ZWaWViSW05R0tLSUtMU1ZLZktjZGZyMXhOSTQ5Q1RxUG50V2RN?= =?utf-8?B?SmV6UVdhUnd2QVVTQmtBakFYVThJb0dEdkhUM2pWS29jbjlrR0xnNWFrb2VW?= =?utf-8?B?OW1ubU8rM3pqZXNybkhPeFQzK3FTSFZQZzRMRnAxOGNCRHBZL0VZR2RCTmI1?= =?utf-8?B?WW5uSC9vR3FvbmNlZ29VMVJscXo5a2RDZVhwKzJIYkQxRWo4L0dJUUNnZUox?= =?utf-8?B?LzFRYlcvdzZ0UjM3dStRY3Y4SlQyN0RKUkZjclpxQnIwQ0FoMlNhTU5YQjRI?= =?utf-8?B?T2VIejEzRkFzVW40MkZaTVY4UFlMWlFBUEpxSU1GbEluMU5mYnZldz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01d8cb3b-bd92-4784-a544-08da4ae82439 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 13:50:12.9472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /pMVyuPqApf67Y5MyEtWRc264ehGLnM8PZ7TfMQsGXVjzynP9wNHdd26Z+dY8wgW0xgPswudvq7woCCtqvN02A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5442 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 10/06/2022 00:59, Alexander Graf wrote: > This patch set speeds up graphics output on ARM by a factor of 60x. > > On most ARM SBCs, we keep the frame buffer in DRAM and map it as cached, > but need it accessible by the display controller which reads directly > from a later point of consistency. Hence, we flush the frame buffer to > DRAM on every change. The full frame buffer. > > Unfortunately, with the advent of 4k displays, we are seeing frame buffers > that can take a while to flush out. This was reported by Da Xue with grub, > which happily print 1000s of spaces on the screen to draw a menu. Every > printed space triggers a cache flush. > > This patch set implements the easiest mitigation against this problem: > Damage tracking. We remember the lowest common denominator region that was > touched since the last video_sync() call and only flush that. The most > typical writer to the frame buffer is the video console, which always > writes rectangles of characters on the screen and syncs afterwards. > > With this patch set applied, we reduce drawing a large grub menu (with > serial console attached for size information) on an RK3399-ROC system > at 1440p from 55 seconds to less than 1 second. > > Version 2 also implements VIDEO_COPY using this mechanism, reducing its > overhead compared to before as well. So even x86 systems should be faster > with this now :). > Series tested on RPi4, thanks a lot! Tested-by: Matthias Brugger > > Alternatives considered: > > 1) Lazy sync - Sandbox does this. It only calls video_sync(true) ever > so often. We are missing timers to do this generically. > > 2) Double buffering - We could try to identify whether anything changed > at all and only draw to the FB if it did. That would require > maintaining a second buffer that we need to scan. > > 3) Text buffer - Maintain a buffer of all text printed on the screen with > respective location. Don't write if the old and new character are > identical. This would limit applicability to text only and is an > optimization on top of this patch set. > > 4) Hash screen lines - Create a hash (sha256?) over every line when it > changes. Only flush when it does. I'm not sure if this would waste > more time, memory and cache than the current approach. It would make > full screen updates much more expensive. > > v1 -> v2: > > - new patch: video: Use VIDEO_DAMAGE for VIDEO_COPY > - Remove ifdefs > - Fix dcache range; we were flushing too much before > - Fix ranges in truetype target > - Limit rotate to necessary damange > > > Alexander Graf (7): > dm: video: Add damage tracking API > dm: video: Add damage notification on display clear > vidconsole: Add damage notifications to all vidconsole drivers > video: Add damage notification on bmp display > efi_loader: GOP: Add damage notification on BLT > video: Only dcache flush damaged lines > video: Use VIDEO_DAMAGE for VIDEO_COPY > > configs/chromebook_coral_defconfig | 1 + > configs/chromebook_link_defconfig | 1 + > configs/chromebook_samus_defconfig | 1 + > configs/minnowmax_defconfig | 1 + > configs/sandbox_defconfig | 1 + > configs/xilinx_zynqmp_virt_defconfig | 1 + > drivers/video/Kconfig | 21 ++- > drivers/video/console_normal.c | 22 ++-- > drivers/video/console_rotate.c | 87 ++++++++----- > drivers/video/console_truetype.c | 30 +++-- > drivers/video/vidconsole-uclass.c | 16 --- > drivers/video/video-uclass.c | 185 ++++++++++++++++----------- > drivers/video/video_bmp.c | 7 +- > include/video.h | 54 +++----- > include/video_console.h | 49 ------- > lib/efi_loader/efi_gop.c | 7 +- > 16 files changed, 247 insertions(+), 237 deletions(-) >