From: "cron2 (Code Review)" Date: Tue, 15 Apr 2025 18:11:52 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <46820b9a38350e0cb134e174d12265985a142cec-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="3UEKXNrMu24="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove UINT8_MAX definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --3UEKXNrMu24= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/94= 0?usp=3Demail ) Change subject: Remove UINT8_MAX definition ...................................................................... Remove UINT8_MAX definition Because this is a part of C99 if uint8_t is available. Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09 Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250415155259.12601-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31= 440.html Signed-off-by: Gert Doering --- M src/openvpn/socket.c 1 file changed, 0 insertions(+), 4 deletions(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index bd7a449..a0c22b1 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -3036,10 +3036,6 @@ return BSTR(&buffer); } -#ifndef UINT8_MAX -#define UINT8_MAX 0xff -#endif - /* add some offset to an ipv6 address * (add in steps of 8 bits, taking overflow into next round) */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09 Gerrit-Change-Number: 940 Gerrit-PatchSet: 2 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --3UEKXNrMu24= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

Remove UINT8_MAX definition

Because thi= s is a part of C99 if uint8_t is available.

Change-Id: I37482a8c3226= 80add00bab52272f9945fbb3bd09
Signed-off-by: Lev Stipakov <lev@...2092...= ..>
Acked-by: Gert Doering <gert@...1296...>
Message-Id: <= ;20250415155259.12601-1-gert@...1296...>
URL: https://www.mail-archiv= e.com/openvpn-devel@lists.sourceforge.net/msg31440.html
Signed-off-by: G= ert Doering <gert@...1296...>
---
M src/openvpn/socket.c
1 f= ile changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index bd7a449..a0c22b1 100644
--- a/src/openvpn/socket.c
+++ b/src/openvpn/socket.c
@@ -3036,10 +3036= ,6 @@
return BSTR(&buffer);
}


-#ifndef= UINT8_MAX
-#define UIN= T8_MAX 0xff
-#endif
-
/* add = some offset to an ipv6 address
* (add in steps of 8 bits,= taking overflow into next round)
*/

To view, visit change 940. To unsubscribe, or for help writing m= ail filters, visit settings<= /a>.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37482a8c322680add00bab52272= f9945fbb3bd09
Gerrit-Change-Number: 940
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--3UEKXNrMu24=--