Reply-To: openvpn-devel@lists.sourceforge.net References: <1515959073-10376-1-git-send-email-selva.nair@...277...> <1515959073-10376-3-git-send-email-selva.nair@...277...> <07f28923-1023-fe7b-2b3e-e57ad3f6bc8f@...2080...> From: David Sommerseth Message-ID: <468ef4ed-11f2-0095-bc96-ab0fe23a91aa@...2080...> Date: Fri, 26 Jan 2018 00:01:21 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QTkyPGMqA8azn6sT4EifrO2e54u8mrf09" Subject: Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Selva Nair , "Jonathan K. Bullard" Cc: openvpn-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QTkyPGMqA8azn6sT4EifrO2e54u8mrf09 Content-Type: multipart/mixed; boundary="cJyoz40wSDZibigyRoBAKeKLDrXWfZF5Y"; protected-headers="v1" From: David Sommerseth Reply-To: openvpn-devel@lists.sourceforge.net To: Selva Nair , "Jonathan K. Bullard" Cc: openvpn-devel Message-ID: <468ef4ed-11f2-0095-bc96-ab0fe23a91aa@...2080...> Subject: Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key References: <1515959073-10376-1-git-send-email-selva.nair@...277...> <1515959073-10376-3-git-send-email-selva.nair@...277...> <07f28923-1023-fe7b-2b3e-e57ad3f6bc8f@...2080...> In-Reply-To: --cJyoz40wSDZibigyRoBAKeKLDrXWfZF5Y Content-Language: en-GB Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 25/01/18 19:46, Selva Nair wrote: > Hi, >=20 > On Thu, Jan 25, 2018 at 1:36 PM, Jonathan K. Bullard > wrote: >> Hi. >> >> On Mon, Jan 22, 2018 at 12:31 PM, Selva Nair wrot= e: >>> What about extending the current "version" command with an argument >>> where the client states the version of "management-speak" that it >>> supports. Current management version is 1, we increase it to 1.1 and >>> unless the client says "version 1.1" or more we do not send PK_SIGN. >>> The client could do that when it gets the version message or any time >>> later. The response to version command (current management version and >>> openvpn daemon's version stays the same). No full-fledged cap >>> negotiation, but good enough. >> >> That sounds reasonable; easy to implement in Tunnelblick >> >> >>> The UX would be much better that way. >> >> Absolutely. >> >=20 > Encouraged by Jonathan's reply I have made a patch to rename RSA_SIGN > to PK_SIGN if client announces a version > 1. Will send it and a > modified EC key patch soon. Sounds good! Just one question ... any reason why to complicate the version number with decimals? Why not just version 1, 2,...X? Coding wise, this is much easier too, as we don't need to do more complicated conversion steps f= rom strings to float. --=20 kind regards, David Sommerseth OpenVPN Inc --cJyoz40wSDZibigyRoBAKeKLDrXWfZF5Y-- --QTkyPGMqA8azn6sT4EifrO2e54u8mrf09 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJaamHBAAoJEIbPlEyWcf3yPCgQAKvg6yaJJzD6Dv50Tp32aPCG nPzjeBN7mNIPFA0RK3icwm+if3XmUPxyA5mrkQXSi1/HMJy2zuPkS308tNBPG7Uc 7aj91YLiONsiRri/W3vZq27qVopSlpQiBWsbiCTiN7Jx5+EluCSzH+W7algW8yG5 uy8G3WkSgSTha/T7kPpkcNOQRxpNGGuYrUPbkcVk1IJitEJ9U2sp5UlxTcIcEGxq iffIbVJrmsjj58wCd++8HdDwGMfAUsMl/u+tVsufwBufsnH1DdIgHeFjxBQbGVFk CqyO5jWEMhHn/fGodEzfidqoc5iLP9vCQzjmCymZESs3X0WrNnYqDSQ34oTalR/w uStn5Kobk9sIqBbRaqnCDBsoYAJmZV47B5cSLJMKul9j3w2m1Kszy7rT09S+uNiA 93Ks2Myr2zrMPwMGLhmcaHMh2FX/AjefvvOiTVU0i6Ns4Q+56J/twzCXjJUZOb05 uTxYd4TdBOrw5AHuJDvrrj5iJPEMJIhogwe3/SfMi80Rv1ldSsgSiLRs5ghNwjLr kxkYxALb7qPmfDPgnWQnsxsb3ffanW2iCjyvnvHAyOzpz8fE5l1uAbRpMMXfxxEo v7LsFAfTlIQ6E72iCFbsoBagBgZH8EtwRBsrsFkSl/l2q6gG4jCy3iWx0GZ5rHvq prvLtwsSRo9hZzwWeH+N =KJsk -----END PGP SIGNATURE----- --QTkyPGMqA8azn6sT4EifrO2e54u8mrf09--