From: Patrick McHardy Subject: Re: [PATCH][netfilter] Avoid a possible NULL pointer deref in recent_seq_open() Date: Mon, 30 Jul 2007 14:28:18 +0200 Message-ID: <46ADD962.4040700@trash.net> References: <200707290308.45464.jesper.juhl@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org, Marc Boucher , Harald Welte , Rusty Russell , Linux Kernel Mailing List , James Morris , coreteam@netfilter.org, Jozsef Kadlecsik , "David S. Miller" To: Jesper Juhl Return-path: In-Reply-To: <200707290308.45464.jesper.juhl@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Jesper Juhl wrote: > There is a small problem in > net/ipv4/netfilter/ipt_recent.c::recent_seq_open(). > > If the call to seq_open() returns != 0 then the code calls > kfree(st) but then on the very next line proceeds to > dereference the pointer - not good. Applied, thanks Jesper.