Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8121C49ED7 for ; Fri, 20 Sep 2019 08:38:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 247F52070C for ; Fri, 20 Sep 2019 08:38:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 247F52070C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46ZRtm1xl5zF1Rd for ; Fri, 20 Sep 2019 18:38:08 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46ZRrV3XrGzDr8q for ; Fri, 20 Sep 2019 18:36:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 46ZRrV2YtTz9sCJ; Fri, 20 Sep 2019 18:36:10 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: d9101bfa6adc831bda8836c4d774820553c14942 In-Reply-To: <20190918145328.28602-1-aneesh.kumar@linux.ibm.com> To: "Aneesh Kumar K.V" From: Michael Ellerman Subject: Re: [RFC PATCH] powerpc/mm/mce: Keep irq disabled during lockless page table walk Message-Id: <46ZRrV2YtTz9sCJ@ozlabs.org> Date: Fri, 20 Sep 2019 18:36:10 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Aneesh Kumar K.V" , Santosh Sivaraj , Reza Arbab , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2019-09-18 at 14:53:28 UTC, "Aneesh Kumar K.V" wrote: > __find_linux_mm_pte return a page table entry pointer walking the > page table without holding locks. To make it safe against a THP > split and collapse, we disable interrupts around the lockless > page table walk. We need to keep the interrupts disabled as long > as we use the page table entry pointer. > > Cc: Balbir Singh > Cc: Reza Arbab > Cc: Santosh Sivaraj > Fixes: ba41e1e1ccb9 ("powerpc/mce: Hookup derror (load/store) UE errors") > Signed-off-by: Aneesh Kumar K.V Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d9101bfa6adc831bda8836c4d774820553c14942 cheers