Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E02C48BE0 for ; Fri, 11 Jun 2021 13:57:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA1FF6136D for ; Fri, 11 Jun 2021 13:57:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA1FF6136D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 185F6804B9; Fri, 11 Jun 2021 15:57:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AOMyHnAm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7504080563; Fri, 11 Jun 2021 15:57:22 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 61AAE804B9 for ; Fri, 11 Jun 2021 15:57:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82e.google.com with SMTP id l17so2580021qtq.12 for ; Fri, 11 Jun 2021 06:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gul108a5zG58ekiZjFyIAZ76AC+44fFjL9yFSvvZMZo=; b=AOMyHnAmce53hJAYdAKSTuBFsj+VjaMHMBQoC8t0rewTdb9O4yJzqyn6oZdET3GWYv celhnHBsDrNqQgBDDuOwPfh3UX6/cKSk0bhKjNCp4EiIjjT4LC7Ysg83M6/01zHgyrP6 Wj3yfc7+L9Yabamk3eV/DFAejL05xvdvFIS/QENVxPEIsDjT+aXn4cH/CoAdo+k0WJt9 pOd3wwTz0qTA+iXUhPiO0oh3lRNbe3ZOuMIJmwglDfvPxCU4SNh15kPrlIFomeOWaC4P Zp7jR6ADdlw2wXxn+bZwPHxwksbJkNd0415Fo7px9hxt8IJZ3ANb6rwyyPx3dPoDZcbl GZ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gul108a5zG58ekiZjFyIAZ76AC+44fFjL9yFSvvZMZo=; b=spoPLxBKECxy8YpvqEzoLlv8xEW3dICvXEL7XgLe0z7uyuyYkCaeHN4DuoNrEroHzw q6lB6OaKWX75FbZXU7kFqG45/8BOWB/29If1Oz9RS/arnFgwy012BqvXWo6TQec4FGL2 TwTWiNuCKwioQipDeg7rolzFExMmzqSequx8k3IG/UosJyV/HROugkfiLwVaj5JwKLtT /UpmaeDZR4VPakEvu43OJOkBZOLXp7en/azWSvW3c3noYQ+VP7jLctvjq64Y5T+MDW/A HodzngLdwOII4+4C+jvUvOd3zsua03ZdqHMC6si5rwZH//nC9MWlafKl03vxs+o0XmGP 2JSA== X-Gm-Message-State: AOAM531NefrsGsQD8PdsHj50L1VtVnUuDSk18aSN33PYdn4ndEjG29XN t6x7AJkIrn0BsQmEnfSNO8U= X-Google-Smtp-Source: ABdhPJxBLTA+F9vhK/45d+DR4HdsWrAAuE4OY98RMVUL8oF2sZsov5o7KNVtm5f2Dr+mRLh/MVpvwA== X-Received: by 2002:ac8:4f03:: with SMTP id b3mr3869015qte.162.1623419837088; Fri, 11 Jun 2021 06:57:17 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id f13sm4192317qtv.83.2021.06.11.06.57.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 06:57:16 -0700 (PDT) Subject: Re: [PATCH v3 00/11] clk: k210: Rewrite K210 clock without CCF To: Lukasz Majewski Cc: u-boot@lists.denx.de, Damien Le Moal , Leo Liang , Andreas Dannenberg , Lokesh Vutla , Philipp Tomsich References: <20210611041617.1665833-1-seanga2@gmail.com> <20210611102124.4f95c62f@ktm> From: Sean Anderson Message-ID: <46c7df49-1e29-3f6c-db81-098e71072baa@gmail.com> Date: Fri, 11 Jun 2021 09:57:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210611102124.4f95c62f@ktm> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 6/11/21 4:21 AM, Lukasz Majewski wrote: > On Fri, 11 Jun 2021 00:16:06 -0400 > Sean Anderson wrote: > >> This is something I've been meaning to do for a while but only just >> got around to. The CCF has been quite unwieldy in a few ways: >> >> * It is very rigid, and there are not easy ways to hook into it >> without rewriting many things. See e.g. things like the bypass clock >> and all the _half clocks which were created because CCF didn't >> support the dividers used on the k210. While preparing this series, I >> encountered several edge cases which I had initially overlooked (or >> which were not supported in the initial release). These would have >> been very difficult to fix with CCF, but were much easier to address >> because each funcion is implemented in one place. >> * There is a lot of magic going on under the curtains because of all >> the CCF code which lives in many different files. Some things live in >> drivers, but many things live in e.g. clk-uclass.c. So many things >> live in so many files and it can be very difficult to get a handle on >> what exactly happens. Complicating this is that there is a conflation >> of struct clk as a handle and struct clk as a device. In this regard, >> refcounting is completely broken. IMO we should just do away with >> refcounts and only disable clocks when explicitly asked for. >> * It is very dependent on runtime initialization. Typically, >> everything is initialized by calling into various register() >> functions, usually with several wrappers to avoid specifying all the >> arguments. This balloons the runtime memory usage since there are so >> many devices created. It also makes it hard to debug, since if you do >> it the "typical" way it is easy to accidentally assign a clock to the >> wrong register. >> * It inflates code size by pulling in not just some dead code (e.g. >> this driver does not use divider tables but they are in clk-divider >> anyway) but also pulling in numerous imx-specific clocks. This could >> be fixed, but I don't want to due to the other reasons listed. >> >> I am very happy to have completely excised it from my driver. IMO >> there should be big warning signs on the CCF warning not to use it >> for new code. This would hopefully dissuade those like myself who had >> no idea that CCF was *not* in fact a good way to write a clock driver. > > You mean for U-Boot or for Linux ? For U-Boot. I wasn't aware that the CCF was mainly designed for porting drivers from Linux. > >> >> Overall there is a total savings of 12k from this series. >> text data bss dec >> hex filename 292485 32672 12624 >> 337781 52775 before/u-boot 283125 >> 29856 12624 325605 4f7e5 after/u-boot >> > > I'm not going to defend CCF to the last breath, I know their issues. > > However, the goal for CCF was to have: > > 1. Ported code from Linux (with some code simplification) > 2. Get the standard approach to the clock subsystem. > > I'm just wondering if we (as a community) want to have such diversity - > I mean each architecture would have different clock driver (under the > device model) If there is already a CCF driver for that arch for Linux, then I think reusing it is OK. However, I think it generally tends toward larger drivers, larger runtime memory usage, and awkward design. So if you are writing a new driver for U-Boot, I think it is better to not use CCF drivers. > > As fair as I can see - the K210 already has support for CCF in Linux: > drivers/clk/clk-k210.c Yes, but it does not really "use" the CCF. For example, things like composite clocks are absent; all calculations of rate are internal to the driver. In fact, I took inspiration from Damien's handling of this driver in Linux. > Reading the above comment - it looks like you couldn't simplyfy this > Linux driver to be smaller and fit into U-Boot? Well, this driver takes major inspiration from the Linux driver, which was itself based on this code. So in a sense, this is already a simplification of the Linux driver. > > Sean, do you think that other archs can benefit from your work? Hm, I don't know. I don't think there is must code which could be reused. Some of the major savings in disabling CCF were from disabling imx-specific clocks which are always enabled, even though they are not designed to be used outside of that arch. In terms of general improvements, I think that get_parent() should be part of clk_ops. That would allow me to use the existing clock dump code. Additionally, I think that enable_count has no business living in struct clk, as that struct is a "thick pointer" and multiple ones can exist for the same clock. --Sean > >> This series depends on >> https://patchwork.ozlabs.org/project/uboot/list/?series=238211 >> >> Changes in v3: >> - Always define clk_defaults_stage, even if clk_set_defaults is a >> dummy >> - Fix inverted condition for setting defaults >> - Fix val not being set for K210_DIV_POWER >> - Add CLK_K210_SET_RATE to defconfig so these changes apply >> >> Changes in v2: >> - Convert stage to enum >> - Only force probe clocks pre-reloc >> - Rebase on u-boot/master >> >> Sean Anderson (11): >> clk: Allow force setting clock defaults before relocation >> clk: k210: Rewrite to remove CCF >> clk: k210: Move pll into the rest of the driver >> clk: k210: Implement soc_clk_dump >> clk: k210: Re-add support for setting rate >> clk: k210: Don't set PLL rates if we are already at the correct rate >> clk: k210: Remove bypass driver >> clk: k210: Move k210 clock out of its own subdirectory >> k210: dts: Set PLL1 to the same rate as PLL0 >> k210: Don't imply CCF >> test: Add K210 PLL tests to sandbox defconfigs >> >> MAINTAINERS | 4 +- >> arch/riscv/dts/k210.dtsi | 2 + >> board/sipeed/maix/Kconfig | 2 - >> configs/sandbox64_defconfig | 2 + >> configs/sandbox_defconfig | 2 + >> configs/sandbox_flattree_defconfig | 2 + >> configs/sipeed_maix_bitm_defconfig | 2 +- >> drivers/clk/Kconfig | 14 +- >> drivers/clk/Makefile | 2 +- >> drivers/clk/clk-uclass.c | 27 +- >> drivers/clk/clk_kendryte.c | 1320 >> +++++++++++++++++++++++ drivers/clk/kendryte/Kconfig | >> 12 - drivers/clk/kendryte/Makefile | 1 - >> drivers/clk/kendryte/bypass.c | 273 ----- >> drivers/clk/kendryte/clk.c | 668 ------------ >> drivers/clk/kendryte/pll.c | 585 ---------- >> drivers/clk/rockchip/clk_rk3308.c | 2 +- >> drivers/core/device.c | 2 +- >> drivers/net/gmac_rockchip.c | 2 +- >> include/clk.h | 30 +- >> include/dt-bindings/clock/k210-sysctl.h | 94 +- >> include/kendryte/bypass.h | 31 - >> include/kendryte/clk.h | 35 - >> include/kendryte/pll.h | 34 - >> 24 files changed, 1437 insertions(+), 1711 deletions(-) >> create mode 100644 drivers/clk/clk_kendryte.c >> delete mode 100644 drivers/clk/kendryte/Kconfig >> delete mode 100644 drivers/clk/kendryte/Makefile >> delete mode 100644 drivers/clk/kendryte/bypass.c >> delete mode 100644 drivers/clk/kendryte/clk.c >> delete mode 100644 drivers/clk/kendryte/pll.c >> delete mode 100644 include/kendryte/bypass.h >> delete mode 100644 include/kendryte/clk.h >> > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de >