From: "cron2 (Code Review)"
Date: Fri, 25 Jul 2025 17:04:49 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
antonio@...2726...
Message-ID: <46cd4dd4aacec241045b3a594744b7f072451326-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="agLSTKDPtVQ="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async
message reception
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--agLSTKDPtVQ=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1100?usp=3Demail )
Change subject: dco_linux: fix async message reception
......................................................................
Patch Set 5:
(1 comment)
File src/openvpn/dco_linux.c:
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/acf86e82_8c8c0854 :
PS4, Line 1189: }
> as mentioned above, MODE_MP may still need to call ovpn_handle_peer()
Now you got me started... if we need to have one function handle both P2P a=
nd P2MP modes anyway, why do we need two functions? They look similar enou=
gh that using `ovpn_handle_peer()` for all `OVPN_CMD_PEER_GET` replies migh=
t just work (possibly moving the peer-id check inside the P2P clause to avo=
id having it in the MP path where it's more like an CANTHAPPEN...)?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I23ad79e14844aefde9ece34dadef0b75ff267201
Gerrit-Change-Number: 1100
Gerrit-PatchSet: 5
Gerrit-Owner: ordex
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Fri, 25 Jul 2025 17:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--agLSTKDPtVQ=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos. <=
/p>
View =
Change
1 comment:
Now you got me started... if we need to have one function handle =
both P2P and P2MP modes anyway, why do we need two functions? They look si=
milar enough that using `ovpn_handle_peer()` for all `OVPN_CMD_PEER_GET` re=
plies might just work (possibly moving the peer-id check inside the P2P cla=
use to avoid having it in the MP path where it's more like an CANTHAPPE=
N...)?
To view, visit change 1100. To unsubscribe, or=
for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I23ad79e14844aefde9ece34dade=
f0b75ff267201
Gerrit-Change-Number: 1100
Gerrit-PatchSet: 5
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Fri, 25 Jul 2025 17:04:49=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--agLSTKDPtVQ=--