From: Michael Walle Subject: Re: [PATCH v2 11/16] gpio: add support for the sl28cpld GPIO controller Date: Thu, 16 Apr 2020 10:55:46 +0200 Message-ID: <46eb76699a76b3feedccc70f1d1da1de@walle.cc> References: <20200402203656.27047-1-michael@walle.cc> <20200402203656.27047-12-michael@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: Linus Walleij Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Thierry Reding , Lee Jones , Jason Cooper , Marc Zyngier , Bartosz Golaszewski , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Guenter Roeck , linux-pwm@vger.kernel.org, Jean Delvare , LINUXWATCHDOG , "open list:GPIO SUBSYSTEM" , Mark Brown , Thomas Gleixner , Wim Van Sebroeck , Linux ARM , linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Rob Herring List-Id: linux-pwm@vger.kernel.org Hi Linus, Am 2020-04-16 10:34, schrieb Linus Walleij: > Hi Michael, > > this is looking good provided we can get the generic GPIO regmap > helper reviewed and merged. Thanks! > > On Thu, Apr 2, 2020 at 10:37 PM Michael Walle wrote: > >> This adds support for the GPIO controller of the sl28 board management >> controller. This driver is part of a multi-function device. >> >> Signed-off-by: Michael Walle > >> + depends on MFD_SL28CPLD > > Apart from this depends it seems the patch is compile-time > independent of the other patches correct. There are no common mfd headers or something like that. > so I'd suggest we just merge > the generic regmap driver and this driver to the GPIO tree once > we feel finished with them, optimistically assuming that the MFD > driver will land and that we will not need any fundamental > changes in the GPIO driver. > > Worst case we have to revert the driver and that is no disaster. Sure. One major thing I'm waiting for is the decision/new ideas on how to handle the "register is not set or zero" problem, see the other thread on the generic regmap gpio. Then I'd respin an update of this whole series. -michael