From: Daniel Schwierzeck Date: Wed, 9 Jan 2019 17:57:33 +0100 Subject: [U-Boot] [PATCH v2 1/7] pinctrl: mscc: Add gpio and pinctrl for Jaguar2 SOC family In-Reply-To: <20190109082148.f7nzg7imc5te26gk@soft-dev3.microsemi.net> References: <1546866154-22418-1-git-send-email-horatiu.vultur@microchip.com> <1546866154-22418-2-git-send-email-horatiu.vultur@microchip.com> <81a04be0-c118-d365-7c4f-408ca2a69337@gmail.com> <20190108080001.6pqfg3jysz5k2g46@soft-dev3.microsemi.net> <20190109082148.f7nzg7imc5te26gk@soft-dev3.microsemi.net> Message-ID: <46fe00ad-8726-12bc-e225-2dde7dd5e263@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 09.01.19 um 09:21 schrieb Horatiu Vultur: > Hi Daniel, > > First, thank you for all the feedback. > > I have created a new patch series that will fix the issue that you > addressed bellow but the fix it would not use compatible string, because > that presume that I need to change the other pinctrl-drivers(ocelot, luton). > I was thinking if it is OK the way I have done in v3 and then create a > new patch series specific for fixing pinctrl. Similar with the issue > that I have for sysreset driver. I didn't expect that you select the registers via compatible strings in the pinctrl driver because you effectively have three drivers and a common driver core. Your v3 variant is perfect. The compatible string method makes sense for drivers that support more than one SoC. The sysreset driver could be an example. -- - Daniel