Message-ID: <472172bb-efba-eafc-3e78-51c112bcd722@...1227...> Date: Thu, 28 Jul 2022 15:47:53 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220625234150.3398864-1-arne@...1227...> From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH v3 1/5] Extract update_session_cipher into standalone function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Gert Doering Cc: openvpn-devel@lists.sourceforge.net Am 27.07.22 um 20:58 schrieb Gert Doering: > Hi, > > On Sun, Jun 26, 2022 at 01:41:46AM +0200, Arne Schwabe wrote: >> + >> +/** >> + * Checks if the cipher is allowed and updates the TLS session cipher with it, >> + * otherwise returns false >> + */ >> +bool >> +update_session_cipher(struct tls_session *session, struct options *options); >> + > > Is that comment correct? I can't find any "updating" here, only "checking". > > What am I overlooking? > It sets options->cipher sometimes but the name is misleading. I will rename to check_session_cipher Arne