From: "flichtenheld (Code Review)"
Date: Tue, 9 Jan 2024 09:35:44 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <472cd653c06c1fbc9d18cc85837bb3b2a3e3d4e1-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="2y+Ms87dpr0="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver:
Show test output always
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , openvpn-devel
--2y+Ms87dpr0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/479?usp=3Demail )
Change subject: forked-test-driver: Show test output always
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> The patch does not do what it promises to do. [=E2=80=A6]
Note that the forked-test-driver is only used for the system tests, not the=
UTs. Your concern was addressed by https://gerrit.openvpn.net/c/openvpn/+/=
485
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514
Gerrit-Change-Number: 479
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Tue, 09 Jan 2024 09:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Gerrit-MessageType: comment
--2y+Ms87dpr0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">Patchset:
Patch Set #5:
The patch does not do =
what it promises to do. [=E2=80=A6]
Note that the forked-test-driver is onl=
y used for the system tests, not the UTs. Your concern was addressed by htt=
ps://gerrit.openvpn.net/c/openvpn/+/485
To view, =
visit cha=
nge 479. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I11e0091482d9acee89ca018374c=
b8d96d22f8514
Gerrit-Change-Number: 479
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Tue, 09 Jan 2024 09:35:44=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Gerrit-MessageType: comment
--2y+Ms87dpr0=--