Received: from eggs.gnu.org ([209.51.188.92]:51046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJfM4-0003Jy-Jr for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJfM3-0007u6-Kc for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:28:04 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJfM3-0007tI-Do for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:28:03 -0400 Received: by mail-wr1-f65.google.com with SMTP id t17so30576228wrw.13 for ; Thu, 25 Apr 2019 07:28:03 -0700 (PDT) References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-8-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <472cdca7-a01f-632f-bbac-633db846c605@redhat.com> Date: Thu, 25 Apr 2019 16:27:58 +0200 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-8-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 07/29] hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com Cc: "Michael S. Tsirkin" , Gerd Hoffmann , "Edgar E . Iglesias" , Jean-Christophe Dubois , Rob Herring , qemu-block@nongnu.org, Andrey Smirnov , Joel Stanley , Antony Pavlov , Alistair Francis , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , Cedric Le Goater , John Snow , Andrew Jeffery , Philippe Mathieu-Daude , Subbaraya Sundeep , Igor Mitsyanko , Jan Kiszka On 4/18/19 8:00 PM, Thomas Huth wrote: > Add Kconfig dependencies for the fsl-imx31 / kzm machine. > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 3 +-- > hw/arm/Kconfig | 4 ++++ > hw/misc/Kconfig | 2 ++ > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 6195b75f48..7f94811ccb 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -10,6 +10,7 @@ CONFIG_PCI_TESTDEV=y > CONFIG_EXYNOS4=y > CONFIG_HIGHBANK=y > CONFIG_INTEGRATOR=y > +CONFIG_FSL_IMX31=y > > CONFIG_VGA=y > CONFIG_NAND=y > @@ -68,7 +69,6 @@ CONFIG_TSC210X=y > CONFIG_BLIZZARD=y > CONFIG_ONENAND=y > CONFIG_TUSB6010=y > -CONFIG_IMX=y > CONFIG_MAINSTONE=y > CONFIG_MPS2=y > CONFIG_MUSCA=y > @@ -115,7 +115,6 @@ CONFIG_ALLWINNER_A10_PIC=y > CONFIG_ALLWINNER_A10=y > > CONFIG_FSL_IMX6=y > -CONFIG_FSL_IMX31=y > CONFIG_FSL_IMX25=y > CONFIG_FSL_IMX7=y > CONFIG_FSL_IMX6UL=y > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index ad3b1f9b40..9087b7d714 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -98,6 +98,10 @@ config FSL_IMX25 > > config FSL_IMX31 > bool > + select SERIAL > + select IMX > + select IMX_I2C > + select LAN9118 Similarly to my comment on patch 6 of this series: Reviewed-by: Philippe Mathieu-Daudé > > config FSL_IMX6 > bool > diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig > index 5f67d0d6d9..385e1b0cec 100644 > --- a/hw/misc/Kconfig > +++ b/hw/misc/Kconfig > @@ -76,6 +76,8 @@ config ECCMEMCTL > config IMX > bool > select PTIMER > + select SSI > + select USB_EHCI_SYSBUS > > config STM32F2XX_SYSCFG > bool >