From: "Jan Beulich" Subject: [PATCH] linux/i386: Use symbolic constants in dump_fault_path() Date: Thu, 06 Dec 2007 15:37:41 +0000 Message-ID: <47582555.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org As usual, written and tested against 2.6.24-rc3 and made apply against 2.6.18 without further testing. Signed-off-by: Jan Beulich Index: head-2007-11-30/arch/i386/mm/fault-xen.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- head-2007-11-30.orig/arch/i386/mm/fault-xen.c 2007-12-06 = 14:56:17.000000000 +0100 +++ head-2007-11-30/arch/i386/mm/fault-xen.c 2007-12-04 09:46:23.0000000= 00 +0100 @@ -231,7 +226,7 @@ static void dump_fault_path(unsigned lon p =3D (unsigned long *)__va(page); p +=3D (address >> 30) * 2; printk(KERN_ALERT "%08lx -> *pde =3D %08lx:%08lx\n", page, p[1], = p[0]); - if (p[0] & 1) { + if (p[0] & _PAGE_PRESENT) { mfn =3D (p[0] >> PAGE_SHIFT) | (p[1] << 20); page =3D mfn_to_pfn(mfn) << PAGE_SHIFT;=20 p =3D (unsigned long *)__va(page); @@ -244,7 +239,7 @@ static void dump_fault_path(unsigned lon if (mfn_to_pfn(mfn) >=3D highstart_pfn) return; #endif - if (p[0] & 1) { + if (p[0] & _PAGE_PRESENT) { page =3D mfn_to_pfn(mfn) << PAGE_SHIFT;=20 p =3D (unsigned long *) __va(page); address &=3D 0x001fffff;