From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen: relax signature check Date: Tue, 11 Dec 2007 09:16:21 -0800 Message-ID: <475EC5E5.80104@goop.org> References: <9yY38-5oa-11@gated-at.bofh.it> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: 7eggert@gmx.de Cc: Andrew Morton , Xen-devel , Linus Torvalds , Linux Kernel Mailing List List-Id: xen-devel@lists.xenproject.org Bodo Eggert wrote: > Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ? > I don't thin Xen version 32 will be compatible ... > It had better be; if it loads the kernel, it should present a xen-3 compatible ABI. But this is just a sanity check to make sure things are basically OK; BUG_ON is hardly nice error reporting (not that there's much else we can do at that point). J