From: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Subject: Re: [2.6 patch] xen: fiddle_vdso() must be __init
Date: Tue, 11 Dec 2007 15:12:33 -0800
Message-ID: <475F1961.10309@citrix.com>
References: <20071211222119.GG14204@stusta.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
In-Reply-To: <20071211222119.GG14204@stusta.de>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Adrian Bunk <bunk@kernel.org>
Cc: chrisw@sous-sol.org, xen-devel@lists.xensource.com, jeremy@xensource.com, Jan Beulich <jbeulich@novell.com>, linux-kernel@vger.kernel.org

Adrian Bunk wrote:
> This patch fixes the following section mismatch:
>
> <--  snip  -->
>
> ...
> WARNING: vmlinux.o(.text+0x2589): Section mismatch: reference to .init.data:vsyscall_int80_start (between 'fiddle_vdso' and 'xen_setup_features')
>   

Jan Beulich just posted a patch to do this, which I acked.

    J

> ...
>
> <--  snip  -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> bd7d683674d639a57c73b316972a28df43690a17 
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index f84e772..5e24f67 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -59,7 +59,7 @@ static void xen_idle(void)
>  /*
>   * Set the bit indicating "nosegneg" library variants should be used.
>   */
> -static void fiddle_vdso(void)
> +static void __init fiddle_vdso(void)
>  {
>  	extern u32 VDSO_NOTE_MASK; /* See ../kernel/vsyscall-note.S.  */
>  	extern char vsyscall_int80_start;
>
>