From: Michael Trimarchi Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch Date: Tue, 16 Sep 2008 13:57:54 +0000 (GMT) Message-ID: <476002.75149.qm@web26206.mail.ukl.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Hisashi Hifumi , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from web26206.mail.ukl.yahoo.com ([217.12.10.243]:22971 "HELO web26206.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753628AbYIPN54 convert rfc822-to-8bit (ORCPT ); Tue, 16 Sep 2008 09:57:56 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, ----- Messaggio originale ----- > Da: Nick Piggin > A: Michael Trimarchi > Cc: Hisashi Hifumi ; akpm@linux-foundat= ion.org; linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org > Inviato: Marted=EC 16 settembre 2008, 14:54:21 > Oggetto: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arc= h >=20 > On Tuesday 16 September 2008 21:11, Michael Trimarchi wrote: > > Hi, > > > > > + if (offset !=3D file_pos_read(file)) > > > + file_pos_write(file, offset); > > > retval =3D offset; > > > } > > > > Is not more efficient here a compare xchg operation? >=20 > The compiler should do it if it was. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kerne= l" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ i was thinking about introducing a file_pos_update() not implemented u= sing=20 file_pos_read()/file_pos_write() and taking the seq_lock or=20 disabling preemption only one time __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da ta= nto spazio gratuito per i tuoi file e i messaggi=20 http://mail.yahoo.it=20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html