From: Anthony Liguori Subject: Re: [PATCH] xen: relax signature check Date: Wed, 12 Dec 2007 13:14:58 -0600 Message-ID: <47603332.8060605@codemonkey.ws> References: <9yY38-5oa-11@gated-at.bofh.it> <475EC5E5.80104@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <475EC5E5.80104@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: 7eggert@gmx.de, Xen-devel , Linus Torvalds , Andrew Morton , Linux Kernel Mailing List List-Id: xen-devel@lists.xenproject.org Jeremy Fitzhardinge wrote: > Bodo Eggert wrote: >> Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ? >> I don't thin Xen version 32 will be compatible ... >> > > It had better be; if it loads the kernel, it should present a xen-3 > compatible ABI. If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible too? I think the point was that you should either be checking for 'xen-3.x' or something more general that would accept anything >= xen-3.0. Regards, Anthony Liguori > But this is just a sanity check to make sure things are basically OK; > BUG_ON is hardly nice error reporting (not that there's much else we can > do at that point). > > J