From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen: relax signature check Date: Wed, 12 Dec 2007 11:36:28 -0800 Message-ID: <4760383C.2040502@goop.org> References: <9yY38-5oa-11@gated-at.bofh.it> <475EC5E5.80104@goop.org> <47603332.8060605@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47603332.8060605@codemonkey.ws> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: 7eggert@gmx.de, Xen-devel , Linus Torvalds , Andrew Morton , Linux Kernel Mailing List List-Id: xen-devel@lists.xenproject.org Anthony Liguori wrote: > If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible > too? I think the point was that you should either be checking for > 'xen-3.x' or something more general that would accept anything >= > xen-3.0. The signature is supposed to be an ABI signature, so regardless of the actual hypervisor version, it should always present "xen-3.0" (presumably backwards compat if it also supports other versions of the ABI). There was a bug in some versions where it puts the actual hypervisor version in there, requiring this patch. Technically that means that looking for "xen-3." is more accurate, but frankly not important enough to bother raising a patch over. J