From: Dmitri Vorobiev Subject: Re: [PATCH v2 8/9] bfs: remove multiple assignments Date: Sun, 27 Jan 2008 02:48:53 +0300 Message-ID: <479BC6E5.5000409@gmail.com> References: <1201296027-6900-1-git-send-email-dmitri.vorobiev@gmail.com> <1201296027-6900-9-git-send-email-dmitri.vorobiev@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: trivial@kernel.org, linux-fsdevel@vger.kernel.org, apw@shadowen.org, rdunlap@xenotime.net, jschopp@austin.ibm.com, Linux-kernel To: Tigran Aivazian Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:50160 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbYAZXtC (ORCPT ); Sat, 26 Jan 2008 18:49:02 -0500 Received: by fg-out-1718.google.com with SMTP id e21so1167086fga.17 for ; Sat, 26 Jan 2008 15:49:00 -0800 (PST) In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Tigran Aivazian wrote: > On Sat, 26 Jan 2008, Dmitri Vorobiev wrote: >> - inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; >> + inode->i_mtime = CURRENT_TIME_SEC; >> + inode->i_atime = CURRENT_TIME_SEC; >> + inode->i_ctime = CURRENT_TIME_SEC; > > multiple assignments like "x = y = z = value;" can potentially > (depending on the compiler and arch) be faster than "x = value; y = > value; z=value;" > > I am surprized that this script complains about them as it is a > perfectly valid thing to do in C. I think it seems wise to ask the maintainers of checkpatch.pl to comment on that. I'm Cc:ing them now. Thanks, Dmitri