From: michael Date: Mon, 11 Feb 2008 22:58:23 +0100 Subject: [U-Boot-Users] [PATCH] ide arm support In-Reply-To: <20080211214823.GA3480@michl.2n.cz> References: <47B0B2D5.5040000@gandalf.sssup.it> <20080211213008.GA11994@game.jcrosoft.org> <20080211214823.GA3480@michl.2n.cz> Message-ID: <47B0C4FF.8070201@gandalf.sssup.it> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi > On Mon, Feb 11, 2008 at 10:30:08PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> On 21:40 Mon 11 Feb , michael wrote: >> >>> --- a/common/cmd_ide.c >>> +++ b/common/cmd_ide.c >>> @@ -934,7 +934,14 @@ output_data(int dev, ulong *sect_buf, int words) >>> static void >>> output_data(int dev, ulong *sect_buf, int words) >>> { >>> +#ifndef __ARM__ >>> outsw(ATA_CURR_BASE(dev)+ATA_DATA_REG, sect_buf, words<<1); >>> +#else >>> + int i = words; >>> >> Why do you initialise "i" with words and re-initialize it at 0 in for? >> > And why do you need this ungly #ifdef at all? > > ladis > > The code is fill with ugly ifdef. Can you suggest me something better? Michael