From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH][retry 3][1/2] new vcpu op call to get
	physicalCPU information
Date: Wed, 05 Mar 2008 08:14:57 +0000
Message-ID: <47CE6491.76E4.0078.0@novell.com>
References: <200803041552.28425.mark.langsdorf@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200803041552.28425.mark.langsdorf@amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>+	short temp =3D 0xff;

Please use 0xffffffff here for forward compatibility.

>+
>+        if ( !opt_dom0_vcpus_pin)
>+            rc =3D -EINVAL;
>+        rc =3D -EFAULT;

This makes no sense; it's probably missing a 'break'.

>+
>+        cpu_id.phys_id =3D x86_cpu_to_apicid[cpu_num];
>+        for (i =3D 0; i++; i < NR_CPUS)=20
>+             if (x86_acpiid_to_apicid[i] =3D=3D x86_cpu_to_apicid[cpu_num=
])
>+                 temp =3D i;
>+	cpu_id.phys_id |=3D temp << 8;

Please shift by 32 here for forward compatibility.

>-static unsigned int opt_dom0_vcpus_pin;
>+unsigned int opt_dom0_vcpus_pin;
>+EXPORT_SYMBOL(opt_dom0_vcpus_pin);

EXPORT_SYMBOL()?

Jan