From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH][retry 3][1/2] new vcpu op call to
	getphysicalCPU information
Date: Wed, 05 Mar 2008 12:34:51 +0000
Message-ID: <47CEA17B.76E4.0078.0@novell.com>
References: <200803041552.28425.mark.langsdorf@amd.com>
	<47CE6491.76E4.0078.0@novell.com>
	<18382.34448.884199.279782@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <18382.34448.884199.279782@mariner.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Mark Langsdorf <mark.langsdorf@amd.com>
List-Id: xen-devel@lists.xenproject.org

>>> Ian Jackson <Ian.Jackson@eu.citrix.com> 05.03.08 12:40 >>>
>Jan Beulich writes ("Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op =
call to get physicalCPU information"):
>> >+	short temp =3D 0xff;
>...
>> >+	cpu_id.phys_id |=3D temp << 8;
>>=20
>> Please shift by 32 here for forward compatibility.
>
>short promotes to int, probably 32-bit, but shifting by the word size
>or more is not permitted.  In any case even if it worked like you
>wanted, the result would be 0.  Perhaps you meant to suggest some
>changes of types as well ?

Of course.

Jan