Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9B9AECAAA1 for ; Mon, 24 Oct 2022 11:54:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A624283F5C; Mon, 24 Oct 2022 13:54:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.b="FcGyVvuJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E2327806E0; Mon, 24 Oct 2022 11:54:39 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2048.outbound.protection.outlook.com [40.107.22.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6BFEE80604 for ; Mon, 24 Oct 2022 11:54:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mikhail.kshevetskiy@iopsys.eu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIpb6sG+4w1mRZ6KMA8uFUexZ0T0uAypIC73V16/JtmoJjZRUjls8ZEds1/xMsozFXQQxYaj8pqZqMGDAuFNPWLNROL/1MssZUm5o3qphI2Dkzj5Z03Ko/btAanhKHdeGrBrzpKasugbftdK1CRMLNl/cGI95wIpC7wwwjNXwY2K5z1lQvzEVEiXSH0J1cmm/+adRI7uZWI28PSJi+rcyXPEQlh7+NWilQ/iZ0EB0ZhXTb+A45WyVmZpuXml5MbUoLnj/Znl2w26AdWq789gQZZEpd2933U52tA5l1HqNdawYNlT6I68NmhjCSJ6TsrwjRyh6260y6xCnAgFZR9zdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pWmo84IIAXnxy+JEIHuuSCPokhCXk7XRrC2ZqEH51aA=; b=V0R2oHMYU6cawrw7FzgMkF0hvctOK09pN30pRQ46WR5haduQ84QNSeiG+vTL1Wm699rfxsdIZI5W4nsXMKw3YFuenuknkD2pZMA1H56G/iwB+H1PiNPbYc9IYhJUsHeoje5b/5Xunljd/BTtBsrC6OwafULJcSfNayg4RFRJIIeEiChPyMbDwI1P1+46U7KK53Oa+tBVfzf24a8GE9dzyMB3N7wj2ilGINwYBFVAxW8fPi58Q7YqHMZNQr2xPYjChFmkIlnpV/xjRtn5Suo67qQ5EYnqds0jafW8eBCq0ogCK7URiIS6NU8y5wT1vpKCzrIfKnaPc3/N5eLbuM2E7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=iopsys.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWmo84IIAXnxy+JEIHuuSCPokhCXk7XRrC2ZqEH51aA=; b=FcGyVvuJWj3m7lN+nn+ta+sFSkq1LVhNZP2bWY5NlrSLnrGNetn3pFPiRdMOMudxZ552gXPLL474i+o5eDEoB3KLgY/xFc/7o9EV5mLIrA/UO/pxjmPL+wzlR3KnSGWtIDM2wSDtcKHIZ7Ni46/gguEgjmOjqyyo6TzaqyqWGDM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from PAXPR08MB6494.eurprd08.prod.outlook.com (2603:10a6:102:154::16) by PA4PR08MB7596.eurprd08.prod.outlook.com (2603:10a6:102:272::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct 2022 09:54:29 +0000 Received: from PAXPR08MB6494.eurprd08.prod.outlook.com ([fe80::4585:194e:af0f:4a46]) by PAXPR08MB6494.eurprd08.prod.outlook.com ([fe80::4585:194e:af0f:4a46%6]) with mapi id 15.20.5723.034; Mon, 24 Oct 2022 09:54:29 +0000 Message-ID: <47b8f03d-c19b-c91c-4268-a355f69e2d68@iopsys.eu> Date: Mon, 24 Oct 2022 12:54:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3] cmd: mtd: check if a block has to be skipped or erased Content-Language: en-US, ru-RU To: Dario Binacchi , u-boot@lists.denx.de Cc: Amarula patchwork , Tom Rini , Jagan Teki , Michael Trimarchi References: <20221024094400.4184355-1-dario.binacchi@amarulasolutions.com> From: Mikhail Kshevetskiy In-Reply-To: <20221024094400.4184355-1-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2PR09CA0018.eurprd09.prod.outlook.com (2603:10a6:101:16::30) To PAXPR08MB6494.eurprd08.prod.outlook.com (2603:10a6:102:154::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6494:EE_|PA4PR08MB7596:EE_ X-MS-Office365-Filtering-Correlation-Id: c83b2767-e9ae-4b3e-8971-08dab5a5be77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XklIkHzUu09RwWYZsZvxYhtlUyLQM5pXd8Y1i7aGnBI5i3UVU+m7j9eG4ffidyP95NNk1yF7RZc0XXIXe8WP+Vdh2VePWxFUTsuzO5F3G8qwj/CEfhID25A/I0LW9c71L2UajSXo5OexWJaIyjJ5erTlreFvMmnnGvCQYOxRGcLvGodVTMsYznwSGnalk/MT8E12JRtSVTSvs+6QcGcf4Nf9S1TVnOiyWoLhC8QV3KbUJZMW0ew4YzhiKpSD2pfHHIwb2/EXb/JFNTxLT3k4VDcr2twN3r6ZFcewuK6G+RJJMa1A7vtnlCurcaobTNzVuJ0TIegNhC3SUfHtkS7KWpAFLsbFA6/vLMdmzUIXE/+W19UU8aaGkWWYJRKF0RTn3wq6jNw+nJTNcXZaL+mWmp1/3hjiSbyEAOdtxvvW/PEBTv9DYrojutu3EIVS+X40fCw+dDU6hIFwFdZgzNzvtk9bQ/Z11wWSViRdKWXk3ONskLsC8vebP9fuJbJ6p3sUtIxqG05odV9zTJDLZ8O/0gykeVwjTWbOXYOogN+xLB0cOh4B9RuPFgbTcPAMcliTSTi6Tu0d7AS4xv9V9vn7gOx8531AM3ZKXTxvV3ZhNn++oYQQeKn+UCzaLgqiYoONoHr8wvY9NCten0HvsTsb7kPN1kCzhoot2JZa3/9VKzYyGmQ/WoW6pYxIs4/4R/agWZEyAV5XX7de/qMVzySyt/TeCm+7Qh10e5Qlm0I0/x4Vtz9e7AnoLmhNly36CmAK5j/nifS/0+zxWDW2cNwEVH/Zb10dmIDJmHJolkGlbZbky87eKfzLDolm2dAv/OoOi4Ppba0IE17hiua+GLVLig== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39840400004)(396003)(346002)(366004)(136003)(376002)(451199015)(186003)(2616005)(83380400001)(86362001)(31696002)(38100700002)(44832011)(2906002)(41300700001)(8936002)(54906003)(5660300002)(966005)(478600001)(53546011)(66946007)(26005)(6486002)(4326008)(66556008)(66476007)(6506007)(45080400002)(8676002)(316002)(6512007)(31686004)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTlxcWx4YnIzTGl4U3RZUkgwY2xCTjRBcmJXcVgvMFJLOHd5aHBIbWdnamkv?= =?utf-8?B?YnNweldlYlNBWmw3MXdPRXNjMnZXb3YyT1RZamh3V0JRemc0SVVWQTNjSVNL?= =?utf-8?B?bXZqeEZ0TWpNV3NWNWp3dXJvcFlTSVBjam1RdHUzNTZHNkpyVVU5dDl1clUv?= =?utf-8?B?NXJvOEFVZFk3M1ZZYmZINGN2L2ZpT1pZTFJuQU1iaEtnTmY2cFp0TXpzeHhq?= =?utf-8?B?b3MvajBoU2EweTI0UU8vd3ZQUnBvYTFWM3IvSDFyaDUxSHdGbWZsSmtDOVI1?= =?utf-8?B?R3BPNGUrWVRIdmlySEpmZGVDZ1NIMURhQ2d2VzRRMGlQdDJMZVFlbkcvM3My?= =?utf-8?B?cnBQVDhKRC9pUWg0M1dDdm9VTFh1NE5lSWlCTkhObWwwZk9xTlFSS3JROWtV?= =?utf-8?B?Q2cvaGo5YVlrSFErcXJoWHYvNEpHZHpjMEFaQzQ3dGxIako1dytaM3hKS3Iv?= =?utf-8?B?TmNYc29HYzIxTkkvS1R5U2gyVDVYUWNidlZ4Rkgrb09BWmZVaFBhODkvazdv?= =?utf-8?B?V1BSNFY5WUN1WFVJMEYxZ05IWGxwc1ArQ1lyRlBGcnp5L3FQaisxVDdOR3NG?= =?utf-8?B?WHpMd3NUc1Zkd3dCaGN6UGpGVmZ5dGV1b1BObXBVVTlGclNZNC9TeURUbzFy?= =?utf-8?B?ZmhMQ29mYnhkQmxFd2JmaWFzZGFXbFhuSGR5c3dXWXVaTGROS1pzeXI5ZVpT?= =?utf-8?B?YmRUT2NzZ1VRS0R6SGpFaTBmTFhHcGJSTUtLRFhlVitZQUFoSEN4YmZGNkdD?= =?utf-8?B?S2tNL2JYWDRnRXZyM2xINXBGalN3Qlc1SThBUWRHaHErd2l5MGJ0TzcwZTBX?= =?utf-8?B?ZFZCUkUrMG9Sd1FwVnVJRzBPWm5pT3ZyNG5HSjQwcjBCNUpuNlcveUl6MmNt?= =?utf-8?B?bnFYRnptdEw1RnREZTg1OXorbWFzYWFQQ29naFNIVkJTWEw3UGtTbFIzc3cy?= =?utf-8?B?SnF2NXlDM0pieGtRN3lZOFA1L2k5dUFqbTVrWHY2MVQvOHZsU2VyNkVrY1NN?= =?utf-8?B?VG8veEw1bHZIRGxMOXhPclM3Skphb0pYNXpaVlNtRWUrSDZjR1RYZ0tCcEtY?= =?utf-8?B?MWxoYVRlQ2ROc1VkVTFGazNHQnpCK0hqUndyWDl0TkNEbUdDMTFOQ2kycUpw?= =?utf-8?B?ODJuNjZSdnZZZWI4bEpnUS93SHpJUWUydmVIT044dHhwRzZQdE56Y1NaV0lZ?= =?utf-8?B?YXI4dnZGVlNtWUNUSk9hTWRxYmduRUVNMWpGRmxtNUFUMTZ3TmRZTjVXTDBk?= =?utf-8?B?aDFwV1ZRNzNpcHJwYXpVaklkdFRFdFYxSzVqZGl6VXZDMngvVi9BRlg3UlZx?= =?utf-8?B?a0ZnNlJHczUyVjBQcCt2dmtNRzJMOElRVXRpUm5BbkM5RUJ3Y2U5cDlWbDBD?= =?utf-8?B?OFF2STBvR2hZTVR0QWFTM3lIQm1lK0ZDTktSdGFCRWhJSlZ5cENNTzF3VThG?= =?utf-8?B?R2hNU3g3TEoyS3IyaTRTRmpGbm8rYnJ0TjNxWjUxcTU5S1dVRmpEdTdRZk1K?= =?utf-8?B?TFVmcmpYQm5rM2RpQWZDS2VhVUxzMnpScGpnZlZxYnNOa3p3U2UwVE1FN2pn?= =?utf-8?B?M25COFNSOHU0YTRFWlNjWU5nNzVoV2s5ZTZsOElYR0FoZjE3anlxNTdmZS9o?= =?utf-8?B?dWJIRHNoL3M3eDBod1c3ZjdiTFJ5cThST0JnVmZpdmQ4czB2RHZJN212MW5W?= =?utf-8?B?SnY0amlxa21PVkpRaGtIZkJnekJncFVDMGFKalF2bTcxUnRUelRwWlQxS2cx?= =?utf-8?B?ZVdaTzNlTkowRElVL1BoeWg1UUkwdW42eUFQTjF0UUx6Z0VWZFdybHdzRlo0?= =?utf-8?B?U2pBYlRnTVRzNkh4VzZvSzIyWHpQUXFKTXZxYXdTcVJXd2llWUs1UXdqU0U0?= =?utf-8?B?WkcvQ1J6V05UQ1R3UStKQWtoTURhZ1FEZC9JbnhUUWtPZkhjTWRxVXNPR2Vi?= =?utf-8?B?ZVVxd01KdkhkRGN1TUEzUUtIKy9UbUFzbTdtVDhQYmVCdFdFMDNGQTFtYzJR?= =?utf-8?B?VGtqWFJ4Q0t6bXlRbUFtMGwwOWhqS1dzTGFGaHdFS0JQaTcvUVkrcCtrRVRE?= =?utf-8?B?TWdXa1NzanZrT2Z4RktQRFZ3TENYSEhjak1JcXF1eFBoV0E3L2oyblNMTUlF?= =?utf-8?B?VzBLbThQbzNqVTIwbVRYZk5xT1VoSThuOHdBNEoxRnA1ZTBXZGdGZFovbVRL?= =?utf-8?Q?Ce+88V4grX2KmG/TVqjgsu8=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: c83b2767-e9ae-4b3e-8971-08dab5a5be77 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 09:54:29.7020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ff78d65-2de4-40f5-8675-0569e5c7a65d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WwBGWFn33qPBCUHCvUBPaEWM/NvViKEptS1/B+J3sKcQCgEYF9nDY4PtKas0W19YOxOBdr2U+K8YEnuhULb35qmiF6dUVULxxkT+5ZpjCeE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7596 X-Mailman-Approved-At: Mon, 24 Oct 2022 13:50:49 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 24.10.2022 12:44, Dario Binacchi wrote: > [External email] > > > > > > From: Mikhail Kshevetskiy > > As reported by patch [1], the `mtd erase' command should not erase bad > blocks. > To force bad block erasing you have to use the `mtd erase.dontskipbad' > command. > > This patch tries to fix the same issue without modifying code taken > from the linux kernel, in order to make further upgrades easier. > > [1] https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20221006031501.110290-2-mikhail.kshevetskiy%40iopsys.eu%2F&data=05%7C01%7Cmikhail.kshevetskiy%40iopsys.eu%7C0ce3c4f03458440084dd08dab5a44a0e%7C7ff78d652de440f586750569e5c7a65d%7C0%7C0%7C638022014468655016%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VMQov1%2FRUmymW2G452jlOveOu2tFCE5MtzssuP2Ri3Y%3D&reserved=0 > Suggested-by: Michael Trimarchi > Co-developed-by: Michael Trimarchi > Signed-off-by: Michael Trimarchi > Co-developed-by: Dario Binacchi > Signed-off-by: Dario Binacchi > Tested-by: Mikhail Kshevetskiy > Signed-off-by: Mikhail Kshevetskiy > > --- > > Changes in v3: > - Simplify the code. mtd_erase() can't return a bad block error. Print > the messaged where the bad block is found. > > Changes in v2: > - Change the commit author > - Do not continue to erase if scrub option is enabled and a bad block > was found but return from the function. > - Update the patch tags. > > cmd/mtd.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/cmd/mtd.c b/cmd/mtd.c > index ad5cc9827d55..29b2a9c04c0c 100644 > --- a/cmd/mtd.c > +++ b/cmd/mtd.c > @@ -434,19 +434,27 @@ static int do_mtd_erase(struct cmd_tbl *cmdtp, int flag, int argc, > erase_op.mtd = mtd; > erase_op.addr = off; > erase_op.len = mtd->erasesize; > - erase_op.scrub = scrub; > > while (len) { > - ret = mtd_erase(mtd, &erase_op); > - > - if (ret) { > - /* Abort if its not a bad block error */ > - if (ret != -EIO) > + if (!scrub) { > + ret = mtd_block_isbad(mtd, erase_op.addr); > + if (ret < 0) { > + printf("Failed to get bad block at 0x%08llx\n", > + erase_op.addr); > + ret = CMD_RET_FAILURE; > + goto out_put_mtd; > + } else if (ret > 0) { > + printf("Skipping bad block at 0x%08llx\n", > + erase_op.addr); > + ret = -EIO; > break; That is bad.//Skipping bad block is an expected behavior. We should not fail on it. > - printf("Skipping bad block at 0x%08llx\n", > - erase_op.addr); > + } > } > > + ret = mtd_erase(mtd, &erase_op); > + if (ret) > + break; > + > len -= mtd->erasesize; > erase_op.addr += mtd->erasesize; > } > -- > 2.32.0 >