Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C271C43381 for ; Fri, 22 Mar 2019 06:39:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32EED218FE for ; Fri, 22 Mar 2019 06:39:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TTvVoswF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727802AbfCVGjk (ORCPT ); Fri, 22 Mar 2019 02:39:40 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42626 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727429AbfCVGjj (ORCPT ); Fri, 22 Mar 2019 02:39:39 -0400 Received: by mail-wr1-f68.google.com with SMTP id g3so1024718wrx.9 for ; Thu, 21 Mar 2019 23:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=F9+3k36FpK8PUOE8ssjThnOtS67rrmHNi2jUDrZfRVE=; b=TTvVoswFODeNH0PAUWgnT5aqSIX/vI173HLvnIgjWykq2HGuNTJrvK0rFU1b/Cupk3 dm1B8+Nsk5ssCPH6q9k7AcgpeRGsjKIKdHhc2vMQ/0+FeQd1ymkFZSP5qXCLcsRS8hYm aLidTeD6/shxLHLVKvP88HOTp8Uz4SvwJuLuja5WZE2We1JbRrkBzXmFfs6xJi3XWkdP iSNTrEu9z6xUyGz4vxENNySm0TexdGmf1+L0JyEyqLXF/1DIjs/xoP9UWw9sDeIQ0OGT C5XeJvDp4uI+aFLJmO3L6/MkB4x7jdFHEIyH3u5BFjzI7kgZ2nO6Psj9pd+EwPLCcvBB hy2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=F9+3k36FpK8PUOE8ssjThnOtS67rrmHNi2jUDrZfRVE=; b=U1dI3N241Bz4Tu+qOP/MBQ64r69VMdLwRKxtHietr1JAkNm7sKOnhwHnUTb8wBnSoB bUvde/TDKWnEb1BHv7Byp+DAQB47z8PZ1/rJzExZVk9yPK+B+EGLvzow+YIYUJo6O9VX yikSXHFgPbyzNCYv+wRB07ePmaayYAhhSSYPCHKzwbZ94ax/CpQoLkmKPKz35smIT829 wgyGC21FrBrPLigMcGv8ZP64MGI9WxwJmL3tiB+LOPWDqrXEY4FMCzw6H0QSkzZtvGBU 3dY2Na6yeZO/b+XVmZYh+e82C1oZBUElWObSSYHkmS18/jakle5rj7GKU/BrPreR2O6H XzDQ== X-Gm-Message-State: APjAAAWW8T9lkdLWc0RhYtdnf9mwXrTltc+oarJaYnsrsg6ttHJ/iQ4o UIW5hKd/YgPK/MAipmiie4zdMHUA X-Google-Smtp-Source: APXvYqwMOlIF13xhO0S3QlFooqKEoITGNArOFaTjh9WLpGu72g8lgEd094pCOhHEouiHi4PAUCD8TQ== X-Received: by 2002:a5d:6682:: with SMTP id l2mr4929567wru.33.1553236777778; Thu, 21 Mar 2019 23:39:37 -0700 (PDT) Received: from ?IPv6:2003:ea:8bc4:dc00:4461:2c05:33c3:cd7f? (p200300EA8BC4DC0044612C0533C3CD7F.dip0.t-ipconnect.de. [2003:ea:8bc4:dc00:4461:2c05:33c3:cd7f]) by smtp.googlemail.com with ESMTPSA id t2sm14737748wra.9.2019.03.21.23.39.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 23:39:37 -0700 (PDT) To: Realtek linux nic maintainers , David Miller Cc: Bartosz Skrzypczak , "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net] r8169: fix cable re-plugging issue Message-ID: <47c70ff0-a38d-8689-2f31-ce6eb71bacb8@gmail.com> Date: Fri, 22 Mar 2019 07:39:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bartek reported that after few cable unplug/replug cycles suddenly replug isn't detected any longer. His system uses a RTL8106, I wasn't able to reproduce the issue with RTL8168g. According to his bisect the referenced commit caused the regression. As Realtek doesn't release datasheets or errata it's hard to say what's the actual root cause, but this change was reported to fix the issue. Fixes: 38caff5a445b ("r8169: handle all interrupt events in the hard irq handler") Reported-by: Bartosz Skrzypczak Suggested-by: Bartosz Skrzypczak Tested-by: Bartosz Skrzypczak Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index a542cd121..a8ca26c2a 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6542,7 +6542,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) set_bit(RTL_FLAG_TASK_RESET_PENDING, tp->wk.flags); } - if (status & RTL_EVENT_NAPI) { + if (status & (RTL_EVENT_NAPI | LinkChg)) { rtl_irq_disable(tp); napi_schedule_irqoff(&tp->napi); } -- 2.21.0