Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A924C43603 for ; Wed, 18 Dec 2019 04:14:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 556F1206EE for ; Wed, 18 Dec 2019 04:14:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 556F1206EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47d1qq2Vh8zDqXd for ; Wed, 18 Dec 2019 15:14:47 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47d1cl68nnzDqD1 for ; Wed, 18 Dec 2019 15:05:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 47d1ck4ZNjz9sS9; Wed, 18 Dec 2019 15:05:10 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 61e3acd8c693a14fc69b824cb5b08d02cb90a6e7 In-Reply-To: <20191209132221.15328-1-ajd@linux.ibm.com> To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH v2] powerpc: Fix __clear_user() with KUAP enabled Message-Id: <47d1ck4ZNjz9sS9@ozlabs.org> Date: Wed, 18 Dec 2019 15:05:10 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot+f25ecf4b2982d8c7a640@syzkaller-ppc64.appspotmail.com, Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 2019-12-09 at 13:22:21 UTC, Andrew Donnellan wrote: > The KUAP implementation adds calls in clear_user() to enable and disable > access to userspace memory. However, it doesn't add these to > __clear_user(), which is used in the ptrace regset code. > > As there's only one direct user of __clear_user(), and the time taken to > set the AMR for KUAP purposes is going to dominate the cost of a quick > access_ok(), there's not much point having a separate path. > > Rename __clear_user() to clear_user_asm(), and make __clear_user() just > call clear_user(). > > Reported-by: syzbot+f25ecf4b2982d8c7a640@syzkaller-ppc64.appspotmail.com > Reported-by: Daniel Axtens > Suggested-by: Michael Ellerman > Cc: Christophe Leroy > Cc: Russell Currey > Fixes: de78a9c42a79 ("powerpc: Add a framework for Kernel Userspace Access Protection") > Signed-off-by: Andrew Donnellan Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/61e3acd8c693a14fc69b824cb5b08d02cb90a6e7 cheers