Message-ID: <47f1e614-6d45-0f58-6398-027a7c7d833b@...2181...> Date: Wed, 22 Jun 2022 11:16:45 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20220524091916.145-1-lstipakov@...277...> From: Antonio Quartulli In-Reply-To: <20220524091916.145-1-lstipakov@...277...> Subject: Re: [Openvpn-devel] [PATCH] Set o->use_peer_id flag for p2p mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Lev Stipakov , openvpn-devel@lists.sourceforge.net Cc: Lev Stipakov Hi, On 24/05/2022 11:19, Lev Stipakov wrote: > From: Lev Stipakov > > There are two flags to indicate peer-id usage, one is > in tls_multi struct and another one is in options. > > For P2P mode we don't set this flag in options, > which is used in MTU calculation. As a result, > automatically calculated MSS value in P2P mode is wrong, > > Fix by bring use_peer_id flag in options and tls_multi > into sync for P2P. > > Signed-off-by: Lev Stipakov Does what it says and creates no side effect. (It's easy to check where o->use_peer_id is used) Moreover, this patch is needed to ensure the p2p case in dco works as expected. Acked-by: Antonio Quartulli -- Antonio Quartulli