Date: Fri, 9 May 2008 13:43:01 +0800
From: Tim Davies <tim@...1090...>
Message-ID: <4823E465.9030500@...1090...>
In-Reply-To: <4823DE56.6040509@...41...>
References: <4811E5AA.8060900@...1090...>
References: <4823DE56.6040509@...41...>
MIME-Version: 1.0
Subject: Re: [Openvpn-devel] [patch] OpenVPN 2.1_rc7, multihome and 64 bit
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, 
	<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, 
	<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain;
	charset="US-ASCII";
	format="flowed"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
To: James Yonan <jim@...41...>
Cc: openvpn-devel@lists.sourceforge.net

I've just tested this and it seems to work well.  Thanks.

James Yonan wrote:
> Tim Davies wrote:
>> After attempting to use OpenVPN 2.1_rc7 on a 64 bit Centos 5 
>> platform, I came across a peculiar error when enabling multihome.  
>> Basically no UDP packets were allowed to send due to an incorrect 
>> size being set.
>>
>> The problem seems to be in socket.c, where sizeof(opi) is incorrect.  
>> The structure is defined as:
>>
>> struct openvpn_pktinfo
>> {
>>  struct cmsghdr cmsghdr;
>>  struct in_pktinfo in_pktinfo;
>> };
>>
>> On a 64 bit platform, sizeof(struct cmsghdr) is 16, and sizeof(struct 
>> in_pktinfo) is 12.  Due to structure padding, sizeof(struct 
>> openvpn_pktinfo) is 32, not 28.
>>
>> The attached patch fixed the problem, although I'm not sure it's the 
>> best way to go about it.
>>
>
>
> I've merged a patch into the subversion directory for the 2.1 series 
> that addresses this using #pragma pack(1)
>
> http://svn.openvpn.net/projects/openvpn/branches/BETA21/openvpn/
>
> It will be included in 2.1-rc8.  Let me know if it fixes the problem.
>
> James
>