From: Chunming Zhou Subject: Re: [PATCH] drm: fix call_kern.cocci warnings v3 Date: Thu, 25 Oct 2018 12:01:19 +0000 Message-ID: <4835ed61-da2b-d205-26a6-09815da787db@amd.com> References: <20181025102105.15412-1-david1.zhou@amd.com> <860e509a-1bff-a2b5-2934-6a2125e8fa40@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <860e509a-1bff-a2b5-2934-6a2125e8fa40@linux.intel.com> Content-Language: en-US Content-ID: <5EBA2D0B84981F488760D07F91200E6E@namprd12.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst , "Zhou, David(ChunMing)" , "dri-devel@lists.freedesktop.org" Cc: =?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , "intel-gfx@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org DQoNCuWcqCAyMDE4LzEwLzI1IDE4OjM2LCBNYWFydGVuIExhbmtob3JzdCDlhpnpgZM6DQo+IE9w IDI1LTEwLTE4IG9tIDEyOjIxIHNjaHJlZWYgQ2h1bm1pbmcgWmhvdToNCj4+IGRyaXZlcnMvZ3B1 L2RybS9kcm1fc3luY29iai5jOjIwMjo0LTE0OiBFUlJPUjogZnVuY3Rpb24gZHJtX3N5bmNvYmpf ZmluZF9zaWduYWxfcHRfZm9yX3BvaW50IGNhbGxlZCBvbiBsaW5lIDM5MCBpbnNpZGUgbG9jayBv biBsaW5lIDM4OSBidXQgdXNlcyBHRlBfS0VSTkVMDQo+Pg0KPj4gICAgRmluZCBmdW5jdGlvbnMg dGhhdCByZWZlciB0byBHRlBfS0VSTkVMIGJ1dCBhcmUgY2FsbGVkIHdpdGggbG9ja3MgaGVsZC4N Cj4+DQo+PiBHZW5lcmF0ZWQgYnk6IHNjcmlwdHMvY29jY2luZWxsZS9sb2Nrcy9jYWxsX2tlcm4u Y29jY2kNCj4+DQo+PiB2MjoNCj4+IHN5bmNvYmotPnRpbWVsaW5lIHN0aWxsIG5lZWRzIHByb3Rl Y3QuDQo+Pg0KPj4gdjM6DQo+PiB1c2UgYSBnbG9iYWwgc2lnbmFsZWQgZmVuY2UgaW5zdGVhZCBv ZiByZS1hbGxvY2F0aW9uLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IENodW5taW5nIFpob3UgPGRh dmlkMS56aG91QGFtZC5jb20+DQo+PiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFu a2hvcnN0QGxpbnV4LmludGVsLmNvbT4NCj4+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnDQo+PiBDYzogQ2hyaXN0aWFuIEvDtm5pZyA8ZWFzeTJyZW1lbWJlci5jaGtAZ29vZ2xl bWFpbC5jb20+DQo+PiAtLS0NCj4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYyAgICAgfCAg MiArKw0KPj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyB8IDUyICsrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tDQo+PiAgIGluY2x1ZGUvZHJtL2RybV9zeW5jb2JqLmgg ICAgIHwgIDEgKw0KPj4gICAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDIxIGRl bGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYw0KPj4gaW5kZXggMzZlOGU5Y2JlYzUyLi4wYTZm MTAyM2Q2YzMgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jDQo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jDQo+PiBAQCAtMzcsNiArMzcsNyBAQA0KPj4g ICAjaW5jbHVkZSA8ZHJtL2RybV9jbGllbnQuaD4NCj4+ICAgI2luY2x1ZGUgPGRybS9kcm1fZHJ2 Lmg+DQo+PiAgICNpbmNsdWRlIDxkcm0vZHJtUC5oPg0KPj4gKyNpbmNsdWRlIDxkcm0vZHJtX3N5 bmNvYmouaD4NCj4+ICAgDQo+PiAgICNpbmNsdWRlICJkcm1fY3J0Y19pbnRlcm5hbC5oIg0KPj4g ICAjaW5jbHVkZSAiZHJtX2xlZ2FjeS5oIg0KPj4gQEAgLTEwMDMsNiArMTAwNCw3IEBAIHN0YXRp YyBpbnQgX19pbml0IGRybV9jb3JlX2luaXQodm9pZCkNCj4+ICAgCWlmIChyZXQgPCAwKQ0KPj4g ICAJCWdvdG8gZXJyb3I7DQo+PiAgIA0KPj4gKwlkcm1fc3luY29ial9zdHViX2ZlbmNlX2luaXQo KTsNCj4+ICAgCWRybV9jb3JlX2luaXRfY29tcGxldGUgPSB0cnVlOw0KPj4gICANCj4+ICAgCURS TV9ERUJVRygiSW5pdGlhbGl6ZWRcbiIpOw0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fc3luY29iai5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMNCj4+IGluZGV4 IGI3ZWFhNjAzZjM2OC4uNmIzZjVhMDZlNGQzIDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9zeW5jb2JqLmMNCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5j DQo+PiBAQCAtODAsNiArODAsMjcgQEAgc3RydWN0IGRybV9zeW5jb2JqX3NpZ25hbF9wdCB7DQo+ PiAgIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7DQo+PiAgIH07DQo+PiAgIA0KPj4gK3N0YXRpYyBz dHJ1Y3QgZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZSBzdHViX3NpZ25hbGVkX2ZlbmNlOw0KPj4gK3N0 YXRpYyB2b2lkIGdsb2JhbF9zdHViX2ZlbmNlX3JlbGVhc2Uoc3RydWN0IGRtYV9mZW5jZSAqZmVu Y2UpDQo+PiArew0KPj4gKwkvKiBpdCBpcyBpbXBvc3NpYmxlIHRvIGNvbWUgaGVyZSAqLw0KPj4g KwlCVUcoKTsNCj4+ICt9DQo+IFdBUk5fT05fT05DRSgxKT8gTm8gbmVlZCB0byBoYWx0IHRoZSBt YWNoaW5lLg0KPg0KPj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX2ZlbmNlX29wcyBnbG9iYWxf c3R1Yl9mZW5jZV9vcHMgPSB7DQo+PiArCS5nZXRfZHJpdmVyX25hbWUgPSBkcm1fc3luY29ial9z dHViX2ZlbmNlX2dldF9uYW1lLA0KPj4gKwkuZ2V0X3RpbWVsaW5lX25hbWUgPSBkcm1fc3luY29i al9zdHViX2ZlbmNlX2dldF9uYW1lLA0KPj4gKwkucmVsZWFzZSA9IGdsb2JhbF9zdHViX2ZlbmNl X3JlbGVhc2UsDQo+PiArfTsNCj4+ICsNCj4+ICt2b2lkIGRybV9zeW5jb2JqX3N0dWJfZmVuY2Vf aW5pdCh2b2lkKQ0KPj4gK3sNCj4+ICsJc3Bpbl9sb2NrX2luaXQoJnN0dWJfc2lnbmFsZWRfZmVu Y2UubG9jayk7DQo+PiArCWRtYV9mZW5jZV9pbml0KCZzdHViX3NpZ25hbGVkX2ZlbmNlLmJhc2Us DQo+PiArCQkgICAgICAgJmdsb2JhbF9zdHViX2ZlbmNlX29wcywNCj4+ICsJCSAgICAgICAmc3R1 Yl9zaWduYWxlZF9mZW5jZS5sb2NrLA0KPj4gKwkJICAgICAgIDAsIDApOw0KPj4gKwlkbWFfZmVu Y2Vfc2lnbmFsKCZzdHViX3NpZ25hbGVkX2ZlbmNlLmJhc2UpOw0KPj4gK30NCj4+ICAgLyoqDQo+ PiAgICAqIGRybV9zeW5jb2JqX2ZpbmQgLSBsb29rdXAgYW5kIHJlZmVyZW5jZSBhIHN5bmMgb2Jq ZWN0Lg0KPj4gICAgKiBAZmlsZV9wcml2YXRlOiBkcm0gZmlsZSBwcml2YXRlIHBvaW50ZXINCj4+ IEBAIC0xMTEsMjQgKzEzMiwxNCBAQCBzdGF0aWMgc3RydWN0IGRtYV9mZW5jZQ0KPj4gICAJCQkJ ICAgICAgdWludDY0X3QgcG9pbnQpDQo+PiAgIHsNCj4+ICAgCXN0cnVjdCBkcm1fc3luY29ial9z aWduYWxfcHQgKnNpZ25hbF9wdDsNCj4+ICsJc3RydWN0IGRtYV9mZW5jZSAqZiA9IE5VTEw7DQo+ PiAgIA0KPj4gKwlzcGluX2xvY2soJnN5bmNvYmotPnB0X2xvY2spOw0KPj4gICAJaWYgKChzeW5j b2JqLT50eXBlID09IERSTV9TWU5DT0JKX1RZUEVfVElNRUxJTkUpICYmDQo+PiAgIAkgICAgKHBv aW50IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkgew0KPj4gLQkJc3RydWN0IGRybV9zeW5jb2JqX3N0 dWJfZmVuY2UgKmZlbmNlID0NCj4+IC0JCQlremFsbG9jKHNpemVvZihzdHJ1Y3QgZHJtX3N5bmNv Ympfc3R1Yl9mZW5jZSksDQo+PiAtCQkJCUdGUF9LRVJORUwpOw0KPj4gLQ0KPj4gLQkJaWYgKCFm ZW5jZSkNCj4+IC0JCQlyZXR1cm4gTlVMTDsNCj4+IC0JCXNwaW5fbG9ja19pbml0KCZmZW5jZS0+ bG9jayk7DQo+PiAtCQlkbWFfZmVuY2VfaW5pdCgmZmVuY2UtPmJhc2UsDQo+PiAtCQkJICAgICAg ICZkcm1fc3luY29ial9zdHViX2ZlbmNlX29wcywNCj4+IC0JCQkgICAgICAgJmZlbmNlLT5sb2Nr LA0KPj4gLQkJCSAgICAgICBzeW5jb2JqLT50aW1lbGluZV9jb250ZXh0LA0KPj4gLQkJCSAgICAg ICBwb2ludCk7DQo+PiAtDQo+PiAtCQlkbWFfZmVuY2Vfc2lnbmFsKCZmZW5jZS0+YmFzZSk7DQo+ PiAtCQlyZXR1cm4gJmZlbmNlLT5iYXNlOw0KPj4gKwkJZG1hX2ZlbmNlX2dldCgmc3R1Yl9zaWdu YWxlZF9mZW5jZS5iYXNlKTsNCj4+ICsJCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsN Cj4+ICsJCXJldHVybiAmc3R1Yl9zaWduYWxlZF9mZW5jZS5iYXNlOw0KPj4gICAJfQ0KPj4gICAN Cj4+ICAgCWxpc3RfZm9yX2VhY2hfZW50cnkoc2lnbmFsX3B0LCAmc3luY29iai0+c2lnbmFsX3B0 X2xpc3QsIGxpc3QpIHsNCj4+IEBAIC0xMzcsOSArMTQ4LDEyIEBAIHN0YXRpYyBzdHJ1Y3QgZG1h X2ZlbmNlDQo+PiAgIAkJaWYgKChzeW5jb2JqLT50eXBlID09IERSTV9TWU5DT0JKX1RZUEVfQklO QVJZKSAmJg0KPj4gICAJCSAgICAocG9pbnQgIT0gc2lnbmFsX3B0LT52YWx1ZSkpDQo+PiAgIAkJ CWNvbnRpbnVlOw0KPj4gLQkJcmV0dXJuIGRtYV9mZW5jZV9nZXQoJnNpZ25hbF9wdC0+ZmVuY2Vf YXJyYXktPmJhc2UpOw0KPj4gKwkJZiA9IGRtYV9mZW5jZV9nZXQoJnNpZ25hbF9wdC0+ZmVuY2Vf YXJyYXktPmJhc2UpOw0KPj4gKwkJYnJlYWs7DQo+PiAgIAl9DQo+PiAtCXJldHVybiBOVUxMOw0K Pj4gKwlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7DQo+PiArDQo+PiArCXJldHVybiBm Ow0KPj4gICB9DQo+PiAgIA0KPj4gICBzdGF0aWMgdm9pZCBkcm1fc3luY29ial9hZGRfY2FsbGJh Y2tfbG9ja2VkKHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaiwNCj4+IEBAIC0xNjYsOSArMTgw LDcgQEAgc3RhdGljIHZvaWQgZHJtX3N5bmNvYmpfZmVuY2VfZ2V0X29yX2FkZF9jYWxsYmFjayhz dHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosDQo+PiAgIAl9DQo+PiAgIA0KPj4gICAJbXV0ZXhf bG9jaygmc3luY29iai0+Y2JfbXV0ZXgpOw0KPj4gLQlzcGluX2xvY2soJnN5bmNvYmotPnB0X2xv Y2spOw0KPj4gICAJKmZlbmNlID0gZHJtX3N5bmNvYmpfZmluZF9zaWduYWxfcHRfZm9yX3BvaW50 KHN5bmNvYmosIHB0X3ZhbHVlKTsNCj4+IC0Jc3Bpbl91bmxvY2soJnN5bmNvYmotPnB0X2xvY2sp Ow0KPj4gICAJaWYgKCEqZmVuY2UpDQo+PiAgIAkJZHJtX3N5bmNvYmpfYWRkX2NhbGxiYWNrX2xv Y2tlZChzeW5jb2JqLCBjYiwgZnVuYyk7DQo+PiAgIAltdXRleF91bmxvY2soJnN5bmNvYmotPmNi X211dGV4KTsNCj4+IEBAIC0zNzksMTEgKzM5MSw5IEBAIGRybV9zeW5jb2JqX3BvaW50X2dldChz dHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosIHU2NCBwb2ludCwgdTY0IGZsYWdzLA0KPj4gICAJ CWlmIChyZXQgPCAwKQ0KPj4gICAJCQlyZXR1cm4gcmV0Ow0KPj4gICAJfQ0KPj4gLQlzcGluX2xv Y2soJnN5bmNvYmotPnB0X2xvY2spOw0KPj4gICAJKmZlbmNlID0gZHJtX3N5bmNvYmpfZmluZF9z aWduYWxfcHRfZm9yX3BvaW50KHN5bmNvYmosIHBvaW50KTsNCj4+ICAgCWlmICghKmZlbmNlKQ0K Pj4gICAJCXJldCA9IC1FSU5WQUw7DQo+PiAtCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2Nr KTsNCj4+ICAgCXJldHVybiByZXQ7DQo+PiAgIH0NCj4+ICAgDQo+PiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vZHJtX3N5bmNvYmouaCBiL2luY2x1ZGUvZHJtL2RybV9zeW5jb2JqLmgNCj4+IGlu ZGV4IDI5MjQ0Y2JjZDA1ZS4uNjNjZmQxNTQwMjQxIDEwMDY0NA0KPj4gLS0tIGEvaW5jbHVkZS9k cm0vZHJtX3N5bmNvYmouaA0KPj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaA0KPj4g QEAgLTE0OCw0ICsxNDgsNSBAQCBpbnQgZHJtX3N5bmNvYmpfZ2V0X2ZkKHN0cnVjdCBkcm1fc3lu Y29iaiAqc3luY29iaiwgaW50ICpwX2ZkKTsNCj4+ICAgaW50IGRybV9zeW5jb2JqX3NlYXJjaF9m ZW5jZShzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosIHU2NCBwb2ludCwgdTY0IGZsYWdzLA0K Pj4gICAJCQkgICAgIHN0cnVjdCBkbWFfZmVuY2UgKipmZW5jZSk7DQo+PiAgIA0KPj4gK3ZvaWQg ZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZV9pbml0KHZvaWQpOw0KPj4gICAjZW5kaWYNCj4gTW92ZSBp dCB0byBkcm1faW50ZXJuYWwuaCA/IFRoaXMgaXMgbm90IGZvciBkcml2ZXIgY29uc3VtcHRpb24u IDopDQoNCj4gaSB3b3VsZCBzcGxpdCB1cCB0aGUgY2hhbmdlcyBhdCB0aGlzIHBvaW50Og0KPg0K PiAxLiBSZXBsYWNlIG1lbW9yeSBhbGxvY2F0aW9uIHdpdGggYSBzdGF0aWMgZmVuY2UsIG5vdCBu ZWNlc3NhcmlseSBjaGFuZ2luZyBhbnkgbG9ja2luZywgYWRkIGEgZml4ZXMgdGFnIHRvIHRoaXMg Y29tbWl0Lg0KPg0KPiAyLiBNb3ZlIGxvY2tpbmcuDQpObyBuZWNlc3NhcnksIHdoeSBjaGFuZ2Ug aXQ/DQoNCj4NCj4gMy4gRml4IGRybV9zeW5jb2JqX2ZlbmNlX2dldF9vcl9hZGRfY2FsbGJhY2sg dG8gcmV0dXJuIGFuIGVycm9yLg0Kd2h5IGRvZXMgaXQgc3RpbGwgbmVlZCBhIHJldHVybiB2YWx1 ZT8gQ2hyaXMgYW5kIEkgYXJlIHRyeWluZyB0byBhdm9pZCB0aGF0Lg0KDQpUaGFua3MsDQpEYXZp ZA0KPg0KPiBUaGF0IHdheSBpdCBzaG91bGQgYmUgbmljZWx5IGJpc2VjdGFibGUuDQo+DQo+IH5N YWFydGVuDQo+DQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=