Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66315C636CA for ; Mon, 19 Jul 2021 01:08:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCB15610CB for ; Mon, 19 Jul 2021 01:08:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCB15610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C2A2B80F4B; Mon, 19 Jul 2021 03:07:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Uf0D6dth"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B231682956; Mon, 19 Jul 2021 03:07:56 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4B76580F2B for ; Mon, 19 Jul 2021 03:07:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1626656871; bh=pTCprZ136tEOR1s1b6AY8Bwe8m8eglQnuHgMF31CJWM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Uf0D6dthgKerKTK8rc7Sppa7/OS4DGZJ+m/WkjJ4rZTKzNDGoPlTTSS/zyFjCgBli 0aLvSCY43o7v6yNASV7H9gcJNExXmc59W2zBN2MOOrVH48N/i/KrKUhEIkJVRXHlKm pK9km3oMSJHgqHRbzt6AmLRrno4fLngUIONeQVFM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgesG-1lSe9z1Y0S-00h3D7; Mon, 19 Jul 2021 03:07:51 +0200 Subject: Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings To: Tom Rini Cc: Simon Glass , U-Boot Mailing List , Alexander Graf , Ilias Apalodimas References: <20210718201426.759240-1-sjg@chromium.org> <20210718201426.759240-5-sjg@chromium.org> <20210719010144.GF9379@bill-the-cat> From: Heinrich Schuchardt Message-ID: <4838b1ef-8ad1-a4da-e3ee-d3daa21ff520@gmx.de> Date: Mon, 19 Jul 2021 03:07:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210719010144.GF9379@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:oHAxC/ARKaTbbVx9CnDwME5F+qNGxjTp81B1wfhBv7s2SovdvC7 iMtj8XLAQxaZ4ORACmrYq5x4D44w7Iz5hkFSu1SKHEeKlovTaYEB0MuTnBUDd9FqOQ0JX4t 0mevdhjFmL4gWu/QRkK0fysXSQGQ56j08zBuLQyg7J4W85CZw0Rv59plNGBd4ahclae+lOD ED4kv0sogo+PiZrmH6CsQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:hZc+u92drmQ=:yXyrQtDX4X6QYvw/P5UfKD 5XPVSCgJOD84Ytxz4pKcdokVii/c5wvfEp0HFOtafLke2jvCfeOaeJb7O8UZ872CdPP9RlRJr dGKRumhD6a++8sdht+z+uAu38xzKlBglnhjrsX0Dc81OUV/7uXRtww9yeIXyP6V/NkHp7LPJy VZ9RBcmmAIRwQtSY1fy380Roz4pfrm3gn+xyhktKXTv+OTyyidpv3waxWrFQ444luCC2E1+Hx jY6lAI3ignaNT+epAi220n8T6Xr2ZX0+E2P+nIDIWfcQUcSHmjJGZDNbGkkoOWLC5aZk9qJ7w 7mA+E03x35Gn6rumOAsaM7Ep3iafxny2w7xVoGPW9pTvwA3bhv9XjJB/oek+SLIGMjUEVl/r6 oai+f1C2nRwhsjvPmNyP/kCviqkxW/yr8EkdXzSICtasXg2Glh11vpFd2F629oUsrRZkqmF69 Lx7wIwLtlz7MMck8htTJC/Z1u+CCzWDKcxhGpJbQZZ4Ik+UdaZkm9VWoFLYABmGLtYDyjZhSs m/Ayz6whvp53fD8eOYRub8mAgqoQ0qG9uELzrbicJUS4f+CpYnPNbwUZ+gZ8gq5qPSdn70ZSr AzRlibpZ15v3jr8qMCrLgigsBZRsXsIk5HDlK5BGjLUzE+FOnuh+3RqYj9nzyocYAWkwCp5/G RAIWrBBs9aDFSdT/lkSVWLlf4l/ScfzScMJtLBL91RWEhVoAx+n7AuloiJA6BOxd1mcC8M/Xt MOkfuXdezqiXZww6QO82wZTb6B1ogZc2FruYiFmYq1Hb6aZIKDNPDLEgJe00pT5CUyU+eFJqa zJdJ04nJQLfB/+3638wvoX9fDTMAegj1/wCOk0jv4u08oNR763SeONN2ctX9ppxquq4/4/XmN s6rXNnMvl4+liuW4SxRxf2f+t1s6ZK9PiMVJ4G6HBKkdeMqio5zMVw7A16nNMnUrOgK1bBGn9 DFYWrCj+IR7lSSE8rH9n5PH9/Iql4S7W4qfyVV5urP6Yz7iJNYGWcexIGMhC59c3WWqNLhY1N UDNvUGJNaOs4YNENYBGUCRmVbVd0cF8IJ98NyUbVvzO4F/6kOTHPL18HdYMVvQ+m9GPUj2STk YmytAWQ4TeZkohyy8H1ImnhrYoIzQiECjhd X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/19/21 3:01 AM, Tom Rini wrote: > On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich Schuchardt wrote: >> On 7/18/21 10:14 PM, Simon Glass wrote: >>> At present we use wide characters for unicode but this is not necessar= y. >>> Change the code to use the 'u' literal instead. This helps to fix buil= d >>> warnings for sandbox on rpi. >>> >>> Signed-off-by: Simon Glass >>> Suggested-by: Heinrich Schuchardt >> >> According to https://en.cppreference.com/w/c/language/string_literal u"= " >> literals are supported since C11. In our Makefile we have CSTD_FLAG := =3D >> -std=3Dgnu11. >> >> Once we have changed all u"" to L"" we can remove -fshort-wchar from ou= r >> Makefiles. Sorry, I meant 'change4 all L"" to u""'. -fshort-wchar interpretes all L"" as 16bit strings. > [snip] >>> diff --git a/include/efi_loader.h b/include/efi_loader.h >>> index b81180cfda8..cad7961942b 100644 >>> --- a/include/efi_loader.h >>> +++ b/include/efi_loader.h >>> @@ -924,7 +924,7 @@ efi_status_t efi_capsule_authenticate(const void *= capsule, >>> efi_uintn_t capsule_size, >>> void **image, efi_uintn_t *image_size); >>> >>> -#define EFI_CAPSULE_DIR L"\\EFI\\UpdateCapsule\\" >>> +#define EFI_CAPSULE_DIR u"\\EFI\\UpdateCapsule\\" > > This brings us more, not less, instances of u"" rather than L"". Should > we perhaps make a coccinelle "spatch" to update everything globally and > drop -fshort-wchar ? >