From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 10 of 12] xen: implement save/restore
Date: Thu, 29 May 2008 09:00:37 +0100
Message-ID: <483E62A5.7060901@goop.org>
References: <patchbomb.1211550067@localhost>
	<9e8d06e5ae8024829836.1211550077@localhost>
	<20080529073150.GA19744@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080529073150.GA19744@elte.hu>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ingo Molnar <mingo@elte.hu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Thomas Gleixner <tglx@linutronix.de>, xen-devel <xen-devel@lists.xensource.com>, LKML <linux-kernel@vger.kernel.org>
List-Id: xen-devel@lists.xenproject.org

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> This patch implements Xen save/restore and migration.
>>     
>
> -tip testing found the following build breakage:
>
>   drivers/built-in.o: In function `xen_suspend':
>   manage.c:(.text+0x4390f): undefined reference to `xen_console_resume'
>
> with this config:
>
>   http://redhat.com/~mingo/misc/config-Thu_May_29_09_23_16_CEST_2008.bad
>
> i have bisected it down to:
>
> |  commit 0e91398f2a5d4eb6b07df8115917d0d1cf3e9b58
> |  Author: Jeremy Fitzhardinge <jeremy@goop.org>
> |  Date:   Mon May 26 23:31:27 2008 +0100
> |
> |      xen: implement save/restore
>
> the problem is that drivers/xen/manage.c is built unconditionally if 
> CONFIG_XEN is enabled and makes use of xen_suspend(), but 
> drivers/char/hvc_xen.c, where the xen_suspend() method is implemented, 
> is only build if CONFIG_HVC_XEN=y as well.
>
> i have solved this by providing a NOP implementation for xen_suspend() 
> in the !CONFIG_HVC_XEN case.
>   

Thanks Ingo, looks good.

Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

    J