From: Jeremy Fitzhardinge Subject: Re: [Xen-devel] [PATCH 10 of 12] xen: implement save/restore Date: Mon, 02 Jun 2008 11:03:36 +0100 Message-ID: <4843C578.6060201@goop.org> References: <9e8d06e5ae8024829836.1211550077@localhost> <20080602092144.GA22955%yamahata@valinux.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080602092144.GA22955%yamahata@valinux.co.jp> Sender: linux-kernel-owner@vger.kernel.org To: Isaku Yamahata Cc: Ingo Molnar , "Rafael J. Wysocki" , Thomas Gleixner , xen-devel , LKML List-Id: xen-devel@lists.xenproject.org Isaku Yamahata wrote: > What is the purpose of load_cr3() here? > I'd like to make this load_cr3() more arch generic for ia64 support. > (or eliminate it if possible) > I think it's an unnecessary left-over from when I was trying to get that stuff to work. I can't think of a good reason not to just remove it if it causes you problems. BTW, I tried to split the suspend/resume stuff into common and things which were definitely x86-specific with you in mind. How close did I get? J