From: Jens Rottmann Subject: Re: "r/o bind mounts" patch in 2.6.26-rc6 changes (breaks?) error behaviour Date: Fri, 20 Jun 2008 18:14:56 +0200 Message-ID: <485BD780.5090103@LiPPERTEmbedded.de> References: <485B8361.6010708@LiPPERTEmbedded.de> <1213971466.7512.17.camel@nimitz> <1213975689.7512.36.camel@nimitz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Al Viro , linux-fsdevel , "linux-kernel@vger.kernel.org" To: Dave Hansen Return-path: Received: from mail.lippert-at.com ([62.80.22.186]:23594 "EHLO domex.lippertembedded.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752787AbYFTQaK (ORCPT ); Fri, 20 Jun 2008 12:30:10 -0400 In-Reply-To: <1213975689.7512.36.camel@nimitz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Dave Hansen wrote: > ... requires a path walk ... ... which is spared only in the error path, the normal path still does the path walk anyway. > Don't you *want* warnings when an 'rm -f' runs into a r/o filesystem? ;) Well, not really. The "rm -f"s are in my startup scripts, supposed to delete stale lock files and lots of stuff that's usually not there unless something went wrong the last time. But most of the time, I leave the whole system mounted R/O, except some tmpfs, dead useful for kernel/hardware hacking/testing. But now I get masses of error messages on bootup - guess I have to litter the scripts with "if [ -e ... ]; then"s or just live with it. :-| Anyway, thanks for solving this mystery for me. :-) Jens