From: "selvanair (Code Review)" Date: Sat, 15 Jun 2024 02:24:53 +0000 References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <485c814b727094012dc7fd722f2548456c331221-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="NDGHIRQ6Zkk="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add test for static-challenge concatenation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --NDGHIRQ6Zkk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/666?usp=3Demail to review the following change. Change subject: Add test for static-challenge concatenation option ...................................................................... Add test for static-challenge concatenation option Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28 --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/666/1 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index b43e655..35fe60d 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -311,7 +311,25 @@ reset_user_pass(&up); - flags |=3D GET_USER_PASS_INLINE_CREDS; + flags |=3D GET_USER_PASS_STATIC_CHALLENGE_CONCAT; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "c1user"); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); + will_return(query_user_exec_builtin, "c1password"); + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "0123456"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "c1user"); + /* password and response concatenated */ + assert_string_equal(up.password, "c1password0123456"); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_STATIC_CHALLENGE|GET_USER_PASS_INLINE_CREDS; /*FIXME: query_user_exec() called even though nothing queued */ will_return(query_user_exec_builtin, true); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/666?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28 Gerrit-Change-Number: 666 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --NDGHIRQ6Zkk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

selvanair would like plaisthos and flichtenheld to review this change.

Vi= ew Change

Add test for static-challenge concatenation option

Cha= nge-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28
---
M tests/unit_te= sts/openvpn/test_user_pass.c
1 file changed, 19 insertions(+), 1 deletio= n(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes=
/66/666/1
diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/=
tests/unit_tests/openvpn/test_user_pass.c
index b43e655..35= fe60d 100644
--- a/tests/unit_tests/openvpn/test_user_pass.= c
+++ b/tests/unit_tests/openvpn/test_user_pass.c@@ -311,7 +311,25 @@

reset_us= er_pass(&up);

- flags |=3D GET_USER_PASS_INLINE_CREDS;
+ flags |=3D GET_USER_PASS_STATIC_CH= ALLENGE_CONCAT;
+
+ expect_string(query= _user_exec_builtin, query_user[i].prompt, "Enter UT Username:");<= /span>
+ will_return(quer= y_user_exec_builtin, "c1user");
+ expect_string(query_user_exec_builtin, query_user= [i].prompt, "Enter UT Password:");
+ will_return(query_user_exec_builtin, "c1p= assword");
+ = will_return(query_user_exec_builtin, true);
+ expect_string(query_user_exec_builtin, query_us= er[i].prompt, "CHALLENGE: Please enter token PIN");
+ will_return(query_user_exec_b= uiltin, "0123456");

+ will_return(query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&= ;up, NULL, "UT", flags, challenge));
+ assert_true(up.defined);
+ assert_string_equal(up.username, &q= uot;c1user");
+ = /* password and response concatenated */
+ assert_string_equal(up.password, "c1passwo= rd0123456");
+
+ reset_user_pass(&= amp;up);
+
= + flags =3D GET_USER_PASS_ST= ATIC_CHALLENGE|GET_USER_PASS_INLINE_CREDS;

/*FIXME: query_user_exec() called even though nothing queued */
will_return(query_user_exec_builtin, true);

To view, visit change 666. To unsubscribe, or for help wri= ting mail filters, visit set= tings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I41f6c1f7acb58f30fc4db0e3250= 5018f64fcad28
Gerrit-Change-Number: 666
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--NDGHIRQ6Zkk=--