From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 00 of 36] x86/paravirt: groundwork for
	64-bit Xen support
Date: Thu, 26 Jun 2008 11:25:54 -0700
Message-ID: <4863DF32.50105@goop.org>
References: <patchbomb.1214367536@localhost> <20080625084253.GA11524@elte.hu>
	<20080625152212.GA3442@elte.hu> <4862A6A9.1030109@goop.org>
	<20080626105722.GA12640@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080626105722.GA12640@elte.hu>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ingo Molnar <mingo@elte.hu>
Cc: Nick Piggin <npiggin@suse.de>, Mark McLoughlin <markmc@redhat.com>, xen-devel <xen-devel@lists.xensource.com>, Eduardo Habkost <ehabkost@redhat.com>, Vegard Nossum <vegard.nossum@gmail.com>, Stephen Tweedie <sct@redhat.com>, x86@kernel.org, LKML <linux-kernel@vger.kernel.org>, Yinghai Lu <yhlu.kernel@gmail.com>
List-Id: xen-devel@lists.xenproject.org

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>  =20
>>> It quickly broke the build in testing:
>>>
>>>  include/asm/pgalloc.h: In function =E2=80=98paravirt_pgd_free':
>>>  include/asm/pgalloc.h:14: error: parameter name omitted
>>>  arch/x86/kernel/entry_64.S: In file included from =20
>>> arch/x86/kernel/traps_64.c:51:include/asm/pgalloc.h: In function=20
>>> =E2=80=98paravirt_pgd_free':
>>>  include/asm/pgalloc.h:14: error: parameter name omitted
>>>  =20
>>>      =20
>> No, looks like my fault.  The non-PARAVIRT version of =20
>> paravirt_pgd_free() is:
>>
>> static inline void paravirt_pgd_free(struct mm_struct *mm, pgd_t *) {}
>>
>> but C doesn't like missing parameter names, even if unused.
>>
>> This should fix it:
>>    =20
>
> that fixed the build but now we've got a boot crash with this config:
>
>  time.c: Detected 2010.304 MHz processor.
>  spurious 8259A interrupt: IRQ7.
>  BUG: unable to handle kernel NULL pointer dereference at  000000000000=
0000
>  IP: [<0000000000000000>]
>  PGD 0
>  Thread overran stack, or stack corrupted
>  Oops: 0010 [1] SMP
>  CPU 0
>  =20

What stage during boot?  I'm seeing an initrd problem, but that's=20
relatively late.

    J